Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kamon-opensearch #1324

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

rgprajeen
Copy link
Contributor

As there is no support for instrumenting OpenSearch 1.x client even though the clients are vastly similar. I have duplicated the instrumentation for ElasticSearch and made the appropriate changes to support the OpenSearch client.

The changes can be summarized as below,

Change package names from com.elasticsearch.client to org.opensearch.client
Change all identifiers from elasticsearch to opensearch
Include necessary libraries

All test cases are green.

@rgprajeen
Copy link
Contributor Author

Hi @hughsimpson , Could you please review this?

@rgprajeen rgprajeen force-pushed the opensearch-instrumentation branch from 2dad5e8 to c53fad3 Compare March 1, 2024 09:00
@hughsimpson
Copy link
Contributor

This seems reasonable to me. Will try to get a passing CI build before merging (curse these flaky tests...)

@hughsimpson hughsimpson merged commit 13b3069 into kamon-io:master Mar 1, 2024
1 check passed
@rgprajeen rgprajeen deleted the opensearch-instrumentation branch March 2, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants