Use ConfigUtil.splitPath to build environment tag keys from a config path #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will look at this tomorrow but seems reasonable |
hughsimpson
approved these changes
Oct 24, 2023
|
Thanks! |
hughsimpson
added a commit
to hughsimpson/Kamon
that referenced
this pull request
Nov 7, 2023
…path (kamon-io#1303) * = kamon-core: add tests that fail using tags with special chars * = kamon-core: Use ConfigUtil.splitPath to build a tag key from a config path * = kamon-core: Improve spec examples and formatting --------- Co-authored-by: hughsimpson <hsimpson@rzsoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config paths are different from config keys, and their difference is explained in the documentation from
com.typesafe.config.Config.The existing implementation uses the config path of kamon environment tags as the keys of a
TagSet. This has the drawback of quoting some tags when it is not necessary. I am not sure if there a reason to assume a tag key corresponds to Config path, I am assuming there is not. Please correct me if I am wrong.This PR tries to avoid quoting of tags by using
ConfigUtil.splitPath()to break and unquote the path.