+kafka: permit specifying custom propagation implementation #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
changed the title
|
relates to #1284 it would be great to add supporting of |
|
@yarosman I think b3 should be pretty similar to the custom implementation I made for the test -- if you're up for implementing it, I'll happily accept a pr to my branch (although I don't need it myself, so tbh probably better to just open separately) |
|
@ivantopo What do you think about merging it ? |
|
Think Ivan's a bit busy with other stuff at the moment so might take a while to get to this - I've been overriding the class locally in the meantime |
|
@yarosman released as 2.6.4, lemme know how it goes |
I hope I will try to integrate it on next week )) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.