Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create dialog component #9

Merged
merged 6 commits into from
Aug 26, 2023
Merged

Conversation

kamo88
Copy link
Owner

@kamo88 kamo88 commented Aug 26, 2023

PR description

  • create dialog component
    • component
    • hooks
    • storybook
capture
before after

Links

issue: #xxx

What you need to review

  • changes

others

others (ex: What we are not doing with this pull request

@kamo88 kamo88 self-assigned this Aug 26, 2023
@kamo88 kamo88 merged commit fd151aa into develop Aug 26, 2023
4 checks passed
@kamo88 kamo88 deleted the feature/create_dialog_component branch August 26, 2023 06:17
kamo88 added a commit that referenced this pull request Aug 26, 2023
kamo88 added a commit that referenced this pull request Aug 26, 2023
* Feature/init vite (#1)

* npm project init

* init vite

* Add engines settings

* Add lint setting (#2)

* Add pr template (#3)

* Add husky & lint-staged (#4)

* feat: Add alias (#5)

* Add workflow settings (#6)

* Feature/storybook (#7)

* Add storybook
Change lint-staged settings

* Add ignore setting storybook

* Add storybook release workflow

* Remove import React

* Feature/create dialog component (#9)

* Add Dialog
Component
hooks

* feat: Add Dialog storybook
useDialog

* feat: Add element in body for portal

* Change customs docs

* Add DialogPromise`s storybook

* feat: Remove initical stories

* Change package-lock npm install

* Remove stories

* Remove preview.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant