develop → main #63
Merged
develop → main #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: Add test case Add early return * refactor: Add test case connect useDialog dialog element * refactor: Add early return useDialogPromise * refactor: Comment out test case * refactor: Change test file extention * refactor: Change data-testId → data-testid * refactor: Add useDialogPromise connect dialog test case Remove unused function * refactor: Add test case in useDialogPromise * refactor: Change prepare test in Dialog Copmponent * refactor: Add DialogContainer handling test case
* docs: Add Component`s usage * chore: version up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
capture
Links
issue: #xxx
What you need to review
others
others (ex: What we are not doing with this pull request