-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivial attempt for Angular 16 #2009
Conversation
|
💻 Website PreviewThe latest changes are available as preview in: https://2cb29cf1.apollo-angular.pages.dev |
Hi there! I noticed that you seem to be missing all the Angular version updates in your dependencies: "@angular-devkit/build-angular": "^16.0.0",
"@angular-devkit/core": "^16.0.0",
"@angular-devkit/schematics": "^16.0.0",
"@angular/animations": "^16.0.0",
"@angular/cli": "^16.0.0",
"@angular/common": "^16.0.0",
"@angular/compiler": "^16.0.0",
"@angular/compiler-cli": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/platform-browser": "^16.0.0",
"@angular/platform-browser-dynamic": "^16.0.0",
"@angular/platform-server": "^16.0.0",
"@angular/router": "^16.0.0",
"ng-packagr": "^16.0.0",
"@schematics/angular": "^16.0.0", However, there is currently one dependency missing Angular 16 compatibility: jest-preset-angular. Once that's resolved, your attempt to upgrade to Angular 16 should be more comprehensive. |
Yeap, this was not meant to be merged as is, but only to see how much would break. Doesn't look too bad so far, but indeed updating our deps is required before merging. |
Great news! jest-preset-angular has been released with version 13.1.0, which is now compatible with Angular 16. With this update, it looks like your dependencies are all set and ready for a successful upgrade to Angular 16. |
I added a PR to fix some low-hanging fruits and removed a test that tested a removed usecase here: #2010 |
Superseded by #2010 |
Checklist:
was reached (not necessary for small changes)