Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial attempt for Angular 16 #2009

Closed
wants to merge 1 commit into from
Closed

Trivial attempt for Angular 16 #2009

wants to merge 1 commit into from

Conversation

PowerKiKi
Copy link
Collaborator

Checklist:

  • If this PR is a new feature, please reference a discussion where a consensus about the design
    was reached (not necessary for small changes)
  • Make sure all the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

⚠️ No Changeset found

Latest commit: 295ef5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

💻 Website Preview

The latest changes are available as preview in: https://2cb29cf1.apollo-angular.pages.dev

@nolotz
Copy link

nolotz commented May 5, 2023

Hi there!

I noticed that you seem to be missing all the Angular version updates in your dependencies:

"@angular-devkit/build-angular": "^16.0.0",
"@angular-devkit/core": "^16.0.0",
"@angular-devkit/schematics": "^16.0.0",
"@angular/animations": "^16.0.0",
"@angular/cli": "^16.0.0",
"@angular/common": "^16.0.0",
"@angular/compiler": "^16.0.0",
"@angular/compiler-cli": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/platform-browser": "^16.0.0",
"@angular/platform-browser-dynamic": "^16.0.0",
"@angular/platform-server": "^16.0.0",
"@angular/router": "^16.0.0",
"ng-packagr": "^16.0.0",
"@schematics/angular": "^16.0.0",

However, there is currently one dependency missing Angular 16 compatibility: jest-preset-angular.
There's a merge request (thymikee/jest-preset-angular#2061) addressing this issue.

Once that's resolved, your attempt to upgrade to Angular 16 should be more comprehensive.

@PowerKiKi PowerKiKi marked this pull request as draft May 6, 2023 02:53
@PowerKiKi
Copy link
Collaborator Author

Yeap, this was not meant to be merged as is, but only to see how much would break. Doesn't look too bad so far, but indeed updating our deps is required before merging.

@nolotz
Copy link

nolotz commented May 6, 2023

Great news! jest-preset-angular has been released with version 13.1.0, which is now compatible with Angular 16. With this update, it looks like your dependencies are all set and ready for a successful upgrade to Angular 16.

@HendrikJanssen
Copy link
Contributor

I added a PR to fix some low-hanging fruits and removed a test that tested a removed usecase here: #2010

@PowerKiKi
Copy link
Collaborator Author

Superseded by #2010

@PowerKiKi PowerKiKi closed this May 8, 2023
@PowerKiKi PowerKiKi deleted the PowerKiKi-patch-1 branch November 22, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants