デフォルトキーマップを廃止して色々整理 #79
Conversation
WalkthroughA new section to handle key mappings for Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
README.md (1)
47-56: Avoid using hard tabs.Use spaces instead of hard tabs for better consistency and readability in Markdown files.
- omap <buffer> im - \ <Plug>(traqvim-message-motion) - nmap <buffer> <LocalLeader>y - \ <Plug>(traqvim-operator-message-yank-link) - nmap <buffer> <LocalLeader>Y - \ <Plug>(traqvim-operator-message-yank-markdown) - nmap <buffer> <LocalLeader>d - \ <Plug>(traqvim-operator-message-delete) - nmap <buffer> <LocalLeader>p - \ <Plug>(traqvim-operator-pin-toggle) + omap <buffer> im + \ <Plug>(traqvim-message-motion) + nmap <buffer> <LocalLeader>y + \ <Plug>(traqvim-operator-message-yank-link) + nmap <buffer> <LocalLeader>Y + \ <Plug>(traqvim-operator-message-yank-markdown) + nmap <buffer> <LocalLeader>d + \ <Plug>(traqvim-operator-message-delete) + nmap <buffer> <LocalLeader>p + \ <Plug>(traqvim-operator-pin-toggle)Tools
Markdownlint
47-47: Column: 1
Hard tabs(MD010, no-hard-tabs)
48-48: Column: 1
Hard tabs(MD010, no-hard-tabs)
49-49: Column: 1
Hard tabs(MD010, no-hard-tabs)
50-50: Column: 1
Hard tabs(MD010, no-hard-tabs)
51-51: Column: 1
Hard tabs(MD010, no-hard-tabs)
52-52: Column: 1
Hard tabs(MD010, no-hard-tabs)
53-53: Column: 1
Hard tabs(MD010, no-hard-tabs)
54-54: Column: 1
Hard tabs(MD010, no-hard-tabs)
55-55: Column: 1
Hard tabs(MD010, no-hard-tabs)
56-56: Column: 1
Hard tabs(MD010, no-hard-tabs)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- README.md (1 hunks)
- doc/traqvim.jax (1 hunks)
- ftplugin/traqvim.vim (1 hunks)
Files skipped from review due to trivial changes (1)
- doc/traqvim.jax
Additional context used
Markdownlint
README.md
47-47: Column: 1
Hard tabs(MD010, no-hard-tabs)
48-48: Column: 1
Hard tabs(MD010, no-hard-tabs)
49-49: Column: 1
Hard tabs(MD010, no-hard-tabs)
50-50: Column: 1
Hard tabs(MD010, no-hard-tabs)
51-51: Column: 1
Hard tabs(MD010, no-hard-tabs)
52-52: Column: 1
Hard tabs(MD010, no-hard-tabs)
53-53: Column: 1
Hard tabs(MD010, no-hard-tabs)
54-54: Column: 1
Hard tabs(MD010, no-hard-tabs)
55-55: Column: 1
Hard tabs(MD010, no-hard-tabs)
56-56: Column: 1
Hard tabs(MD010, no-hard-tabs)
Additional comments not posted (4)
ftplugin/traqvim.vim (4)
16-16: Ensure the functiontraqvim#registerYankMessageLinkexists and is correctly implemented.The key mapping
<Plug>(traqvim-operator-message-yank-link)is bound totraqvim#registerYankMessageLink().
25-25: Ensure the functiontraqvim#message_motionexists and is correctly implemented.The key mapping
<Plug>(traqvim-message-motion)is bound totraqvim#message_motion().
20-20: Ensure the functiontraqvim#registerDeleteMessageexists and is correctly implemented.The key mapping
<Plug>(traqvim-operator-message-delete)is bound totraqvim#registerDeleteMessage().
22-22: Ensure the functiontraqvim#registerTogglePinexists and is correctly implemented.The key mapping
<Plug>(traqvim-operator-pin-toggle)is bound totraqvim#registerTogglePin().Verification successful
The function
traqvim#registerTogglePinexists and is correctly implemented.
- The function is defined in
autoload/traqvim.vim.- The key mapping
<Plug>(traqvim-operator-pin-toggle)is correctly referenced in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and implementation of `traqvim#registerTogglePin`. # Test: Search for the function definition. Expect: The function is defined and implemented properly. ast-grep --lang vimscript --pattern $'function! traqvim#registerTogglePin()'Length of output: 196
Script:
#!/bin/bash # Description: Verify the existence and implementation of `traqvim#registerTogglePin`. # Test: Search for the function definition. Expect: The function is defined and implemented properly. rg 'function!\s*traqvim#registerTogglePin' --glob '*.vim'Length of output: 59
Script:
#!/bin/bash # Description: Verify the existence and implementation of `traqvim#registerTogglePin` and check the key mapping. # Test 1: Search for any references to the function `traqvim#registerTogglePin` in the entire codebase. rg 'traqvim#registerTogglePin' # Test 2: Check the key mapping for <Plug>(traqvim-operator-pin-toggle). rg '<Plug>\(traqvim-operator-pin-toggle\)'Length of output: 421
| \ traqvim#registerYankMessageLink() | ||
| nnoremap <buffer><expr> <Plug>(traqvim-yank-message-markdown-operator) | ||
| nnoremap <buffer><expr> <Plug>(traqvim-operator-message-yank-markdown) |
There was a problem hiding this comment.
Tip
Codebase Verification
Function traqvim#registerYankMessageMarkdown not found
The function traqvim#registerYankMessageMarkdown does not exist in the codebase. This means the key mapping <Plug>(traqvim-operator-message-yank-markdown) is invalid and will not work as intended. Please define the function or correct the key mapping.
- File:
ftplugin/traqvim.vim - Line: 18
Analysis chain
Ensure the function traqvim#registerYankMessageMarkdown exists and is correctly implemented.
The key mapping <Plug>(traqvim-operator-message-yank-markdown) is bound to traqvim#registerYankMessageMarkdown().
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence and implementation of `traqvim#registerYankMessageMarkdown`.
# Test: Search for the function definition. Expect: The function is defined and implemented properly.
ast-grep --lang vimscript --pattern $'function! traqvim#registerYankMessageMarkdown()'
Length of output: 206
Script:
#!/bin/bash
# Description: Verify the existence and implementation of `traqvim#registerYankMessageMarkdown`.
# Test: Search for the function definition. Expect: The function is defined and implemented properly.
rg 'function! traqvim#registerYankMessageMarkdown'
Length of output: 52
Script:
#!/bin/bash
# Description: Search for any functions that include "traqvim" in their name to ensure we haven't missed any relevant definitions.
# Test: Search for all function definitions that include "traqvim". Expect: To find relevant functions if they exist.
rg 'function!.*traqvim'
Length of output: 823
kamecha
force-pushed
the
refacter/delete-default-keymap
branch
from
a043d98
to
3592c53
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- README.md (1 hunks)
- doc/traqvim.jax (1 hunks)
- ftplugin/traqvim.vim (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- doc/traqvim.jax
- ftplugin/traqvim.vim
Additional context used
Markdownlint
README.md
47-47: Column: 1
Hard tabs(MD010, no-hard-tabs)
48-48: Column: 1
Hard tabs(MD010, no-hard-tabs)
49-49: Column: 1
Hard tabs(MD010, no-hard-tabs)
50-50: Column: 1
Hard tabs(MD010, no-hard-tabs)
51-51: Column: 1
Hard tabs(MD010, no-hard-tabs)
52-52: Column: 1
Hard tabs(MD010, no-hard-tabs)
53-53: Column: 1
Hard tabs(MD010, no-hard-tabs)
54-54: Column: 1
Hard tabs(MD010, no-hard-tabs)
55-55: Column: 1
Hard tabs(MD010, no-hard-tabs)
56-56: Column: 1
Hard tabs(MD010, no-hard-tabs)
Additional comments not posted (1)
README.md (1)
44-44: LGTM!The autocmd command correctly calls the
s:traqvim_settingfunction when thetraqvimfile type is detected.
| omap <buffer> im | ||
| \ <Plug>(traqvim-motion-message) | ||
| nmap <buffer> <LocalLeader>y | ||
| \ <Plug>(traqvim-operator-message-yank-link) | ||
| nmap <buffer> <LocalLeader>Y | ||
| \ <Plug>(traqvim-operator-message-yank-markdown) | ||
| nmap <buffer> <LocalLeader>d | ||
| \ <Plug>(traqvim-operator-message-delete) | ||
| nmap <buffer> <LocalLeader>p | ||
| \ <Plug>(traqvim-operator-pin-toggle) |
There was a problem hiding this comment.
Replace hard tabs with spaces.
The use of hard tabs violates Markdownlint rules (MD010). Replace hard tabs with spaces for consistent formatting.
- omap <buffer> im
- \ <Plug>(traqvim-motion-message)
- nmap <buffer> <LocalLeader>y
- \ <Plug>(traqvim-operator-message-yank-link)
- nmap <buffer> <LocalLeader>Y
- \ <Plug>(traqvim-operator-message-yank-markdown)
- nmap <buffer> <LocalLeader>d
- \ <Plug>(traqvim-operator-message-delete)
- nmap <buffer> <LocalLeader>p
- \ <Plug>(traqvim-operator-pin-toggle)
+ omap <buffer> im
+ \ <Plug>(traqvim-motion-message)
+ nmap <buffer> <LocalLeader>y
+ \ <Plug>(traqvim-operator-message-yank-link)
+ nmap <buffer> <LocalLeader>Y
+ \ <Plug>(traqvim-operator-message-yank-markdown)
+ nmap <buffer> <LocalLeader>d
+ \ <Plug>(traqvim-operator-message-delete)
+ nmap <buffer> <LocalLeader>p
+ \ <Plug>(traqvim-operator-pin-toggle)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| omap <buffer> im | |
| \ <Plug>(traqvim-motion-message) | |
| nmap <buffer> <LocalLeader>y | |
| \ <Plug>(traqvim-operator-message-yank-link) | |
| nmap <buffer> <LocalLeader>Y | |
| \ <Plug>(traqvim-operator-message-yank-markdown) | |
| nmap <buffer> <LocalLeader>d | |
| \ <Plug>(traqvim-operator-message-delete) | |
| nmap <buffer> <LocalLeader>p | |
| \ <Plug>(traqvim-operator-pin-toggle) | |
| omap <buffer> im | |
| \ <Plug>(traqvim-motion-message) | |
| nmap <buffer> <LocalLeader>y | |
| \ <Plug>(traqvim-operator-message-yank-link) | |
| nmap <buffer> <LocalLeader>Y | |
| \ <Plug>(traqvim-operator-message-yank-markdown) | |
| nmap <buffer> <LocalLeader>d | |
| \ <Plug>(traqvim-operator-message-delete) | |
| nmap <buffer> <LocalLeader>p | |
| \ <Plug>(traqvim-operator-pin-toggle) |
Tools
Markdownlint
47-47: Column: 1
Hard tabs(MD010, no-hard-tabs)
48-48: Column: 1
Hard tabs(MD010, no-hard-tabs)
49-49: Column: 1
Hard tabs(MD010, no-hard-tabs)
50-50: Column: 1
Hard tabs(MD010, no-hard-tabs)
51-51: Column: 1
Hard tabs(MD010, no-hard-tabs)
52-52: Column: 1
Hard tabs(MD010, no-hard-tabs)
53-53: Column: 1
Hard tabs(MD010, no-hard-tabs)
54-54: Column: 1
Hard tabs(MD010, no-hard-tabs)
55-55: Column: 1
Hard tabs(MD010, no-hard-tabs)
56-56: Column: 1
Hard tabs(MD010, no-hard-tabs)
Close #78
ユーザーの設定と競合しないように、設定フレンドリーになりたいよね
Summary by CodeRabbit
New Features
traqvimplugin.Documentation
doc/traqvim.jaxwith new key mappings for message operations.Refactor
ftplugin/traqvim.vimfor consistency and clarity.