-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
メッセージについてるスタンプを表示 #104
Merged
Merged
メッセージについてるスタンプを表示 #104
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
61661e7
stampとuser用のAPIをdispatcherに登録
kamecha 8169455
スタンプを折り畳みで表示
kamecha bfe3997
折り畳みのstamp表記の取得でユーザー名に:があっても大丈夫にした
kamecha 49376f2
stampとuserのキャッシュを使用
kamecha 310cd9d
bench用コードも一応あげとく
kamecha 3f1160f
fix typo for cache
kamecha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
import { traq } from "./deps.ts"; | ||
import { | ||
channelMessageOptions, | ||
channelTimeline, | ||
channelUUID, | ||
getStamp, | ||
getUser, | ||
homeChannelId, | ||
} from "./model.ts"; | ||
import { Message } from "./type.d.ts"; | ||
import { api } from "./api.ts"; | ||
|
||
api.tokenFilePath = ""; | ||
|
||
let channelId: string; | ||
|
||
// $ deno bench --allow-read --allow-net -- --#gps/times/kamecha | ||
if (Deno.args.length > 0) { | ||
// --#gps/times/kamecha | ||
const channelPath = Deno.args[0]; | ||
// --#gps/times/kamecha -> ["gps", "times", "kamecha"] | ||
const channelPathArray = channelPath.slice(3).split("/"); | ||
channelId = await channelUUID(channelPathArray) ?? ""; | ||
} else { | ||
channelId = await homeChannelId(); | ||
} | ||
|
||
const timelineOption: channelMessageOptions = { | ||
id: channelId, | ||
limit: 10, | ||
until: new Date().toISOString(), | ||
inclusive: true, | ||
order: "desc", | ||
}; | ||
|
||
const messages: Message[] = await channelTimeline(timelineOption); | ||
|
||
console.log("messages length:", messages.length); | ||
|
||
for (const message of messages) { | ||
console.log("stamps length:", message.stamps.length); | ||
} | ||
|
||
Deno.bench("user & stamp chache", async (b: Deno.BenchContext) => { | ||
const userCache: Record<string, traq.User> = {}; | ||
const stampCache: Record<string, traq.Stamp> = {}; | ||
b.start(); | ||
for (const message of messages) { | ||
for (const stamp of message.stamps) { | ||
if (!stampCache[stamp.stampId]) { | ||
stampCache[stamp.stampId] = await getStamp(stamp.stampId); | ||
} | ||
if (!userCache[stamp.userId]) { | ||
userCache[stamp.userId] = await getUser(stamp.userId); | ||
} | ||
} | ||
} | ||
b.end(); | ||
}); | ||
kamecha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Deno.bench("stamp cache", async (b: Deno.BenchContext) => { | ||
const stampCache: Record<string, traq.Stamp> = {}; | ||
b.start(); | ||
for (const message of messages) { | ||
for (const stamp of message.stamps) { | ||
if (!stampCache[stamp.stampId]) { | ||
stampCache[stamp.stampId] = await getStamp(stamp.stampId); | ||
} | ||
await getUser(stamp.userId); | ||
} | ||
} | ||
b.end(); | ||
}); | ||
|
||
Deno.bench("user chache", async (b: Deno.BenchContext) => { | ||
const userCache: Record<string, traq.User> = {}; | ||
b.start(); | ||
for (const message of messages) { | ||
for (const stamp of message.stamps) { | ||
await getStamp(stamp.stampId); | ||
if (!userCache[stamp.userId]) { | ||
userCache[stamp.userId] = await getUser(stamp.userId); | ||
} | ||
} | ||
} | ||
b.end(); | ||
}); | ||
kamecha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Deno.bench("no chache", async (b: Deno.BenchContext) => { | ||
b.start(); | ||
for (const message of messages) { | ||
for (const stamp of message.stamps) { | ||
await getStamp(stamp.stampId); | ||
await getUser(stamp.userId); | ||
} | ||
} | ||
b.end(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize asynchronous requests for stamps and users.
The use of
denops#request
within a loop for fetching stamp and user data could lead to performance bottlenecks due to multiple asynchronous calls. Consider implementing a caching mechanism or batching requests to improve performance.