Retain volatile optional pcb settings #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great contribution, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional PCB commands
SetDemandControlandSetSmartGridModeare neither written to any memory, nor are they published by heishamon to mqtt.In order to retain the selected values in home assistant on page refresh and reboots and to reapply the values after an heishamon reset or reboot, I've set the mqtt flag
retainto true of these commands and changed the subscribed mqtt topic to the actual command topics.This way we have the mentioned benefits (keep values in HA, reapply values after heishamon reboot).
I couldn't think of any negative implications or reasons why we wouldn't want this behavior.
In contrast to regular (non-optional-pcb) commands like
SetQuietMode, which are stored in the heat pump's memory, we shouldn't even have write cycles on the EEPROM as they are volatile.