Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-9471): slider progress bar exceeds 100% #20

Merged
merged 3 commits into from
Dec 5, 2019
Merged

fix(FEC-9471): slider progress bar exceeds 100% #20

merged 3 commits into from
Dec 5, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Dec 2, 2019 •
edited
Loading

Description of the Changes

Made the flash behave more similar to HTML5 where updating the currentTime really updates the value of the currentTime and then it changes when playback continues. This is required so that in the "Seeking" event the currentTime will show the target currentTime and not the current one before the seek

solves FEC-9471

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Yuvalke
Yuvalke previously approved these changes Dec 5, 2019
View reviewed changes
@RoyBregman RoyBregman merged commit fafad30 into master Dec 5, 2019
@RoyBregman RoyBregman deleted the FEC-9471-slider-exceed branch December 5, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyBregman @Yuvalke