fix: drop out-of-bound coords in reducer #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix from kalkih#251 introduced a logic that 1. allocated all "too-old" coords to the first group coords[0] 2. deleted all but one entries from that first group. This caused aggregators to stop calculating proper results for that first group. The proposed new logic drops out-of-bounds entries already in the reducer. This allows the first group to have multiple entries. Aggregate functions should now work again.
I had to understand it to see, if the change in in histGroups would break something. And I could not really follow. So, this makes it easier for others I hope.
akloeckner
force-pushed
the
fix/min-max-avg
branch
from
88f16dc to
2d09da3
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2023
# [0.12.0-dev.1](v0.11.0...v0.12.0-dev.1) (2023-04-22) ### Bug Fixes * add first datapoint tooltip for line graph ([#882](#882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [#805](#805) * drop out-of-bound coords in reducer ([#881](#881)) ([527f005](527f005)), closes [#251](#251) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [#872](#872) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) ### Features * **option:** override icon with an image URL ([#789](#789)) ([2860a09](2860a09))
|
🎉 This PR is included in version 0.12.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
akloeckner
added a commit
to akloeckner/mini-graph-card
that referenced
this pull request
Apr 26, 2023
This re-insures the logic to keep the last known state before the start of our grah interval within the history. While this is not really correct, it allows for rendering state-state-graphs. This element was mistakenly removed in kalkih#881. The piece of code relies on history being chronographical. fixes kalkih#960
akloeckner
added a commit
to akloeckner/mini-graph-card
that referenced
this pull request
Apr 26, 2023
This re-insures the logic to keep the last known state before the start of our grah interval within the history. While this is not really correct, it allows for rendering steady-state-graphs. This element was mistakenly removed in kalkih#881. The piece of code relies on history being chronographical. fixes kalkih#960
akloeckner
added a commit
that referenced
this pull request
Apr 27, 2023
This re-insures the logic to keep the last known state before the start of our grah interval within the history. While this is not really correct, it allows for rendering steady-state-graphs. This element was mistakenly removed in #881. The piece of code relies on history being chronographical. fixes #960
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2024
# [0.12.0](v0.11.0...v0.12.0) (2024-01-27) ### Bug Fixes * add first datapoint tooltip for line graph ([#882](#882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [#805](#805) * cards would always assume icon_image was set ([#957](#957)) ([f376732](f376732)) * drop out-of-bound coords in reducer ([#881](#881)) ([527f005](527f005)), closes [#251](#251) * retain the last out-of-bounds state ([#961](#961)) ([8ebe173](8ebe173)), closes [#881](#881) [#960](#960) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [#872](#872) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) ### Features * Add support of attribute tree when available ([#996](#996)) ([9c1c31e](9c1c31e)) * pull two years worth of changes into release channel ([f5fb98d](f5fb98d)), closes [#1059](#1059) * **option:** override icon with an image URL ([#789](#789)) ([2860a09](2860a09))
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to motorlatitude/mini-graph-card
that referenced
this pull request
Dec 15, 2024
# 1.0.0 (2024-12-15) ### Bug Fixes * add first datapoint tooltip for line graph ([kalkih#882](https://github.com/motorlatitude/mini-graph-card/issues/882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [kalkih#805](https://github.com/motorlatitude/mini-graph-card/issues/805) * cards would always assume icon_image was set ([kalkih#957](https://github.com/motorlatitude/mini-graph-card/issues/957)) ([f376732](f376732)) * display a warning if entity is not available ([kalkih#545](https://github.com/motorlatitude/mini-graph-card/issues/545)) ([a334b84](a334b84)), closes [kalkih#487](https://github.com/motorlatitude/mini-graph-card/issues/487) * drop out-of-bound coords in reducer ([kalkih#881](https://github.com/motorlatitude/mini-graph-card/issues/881)) ([527f005](527f005)), closes [kalkih#251](https://github.com/motorlatitude/mini-graph-card/issues/251) * Fix undefined variable introduced by [kalkih#545](https://github.com/motorlatitude/mini-graph-card/issues/545) ([9e923f5](9e923f5)) * icon will properly follow entity's device_class [[kalkih#484](https://github.com/motorlatitude/mini-graph-card/issues/484)] ([2f9e0a7](2f9e0a7)) * retain the last out-of-bounds state ([kalkih#961](https://github.com/motorlatitude/mini-graph-card/issues/961)) ([8ebe173](8ebe173)), closes [kalkih#881](https://github.com/motorlatitude/mini-graph-card/issues/881) [kalkih#960](https://github.com/motorlatitude/mini-graph-card/issues/960) * Support for `fire-dom-event` ([c29f55f](c29f55f)), closes [kalkih#563](https://github.com/motorlatitude/mini-graph-card/issues/563) * tooltip interval start could be after end ([kalkih#1065](https://github.com/motorlatitude/mini-graph-card/issues/1065)) ([930ee39](930ee39)), closes [kalkih#181](https://github.com/motorlatitude/mini-graph-card/issues/181) * **config:** Remove entity config error [kalkih#592](https://github.com/motorlatitude/mini-graph-card/issues/592) ([kalkih#593](https://github.com/motorlatitude/mini-graph-card/issues/593)) ([53d923a](53d923a)) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [kalkih#872](https://github.com/motorlatitude/mini-graph-card/issues/872) * **log:** color_thresholds render incorectly with logaritmic on ([kalkih#542](https://github.com/motorlatitude/mini-graph-card/issues/542)) ([b704885](b704885)), closes [kalkih#531](https://github.com/motorlatitude/mini-graph-card/issues/531) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) * Time would sometime display 24:xx instead of 00:xx [[kalkih#536](https://github.com/motorlatitude/mini-graph-card/issues/536)] ([7c7d921](7c7d921)) ### Features * Add support of attribute tree when available ([kalkih#996](https://github.com/motorlatitude/mini-graph-card/issues/996)) ([9c1c31e](9c1c31e)) * Interpolate color threshold stops ([kalkih#596](https://github.com/motorlatitude/mini-graph-card/issues/596)) ([3826c0d](3826c0d)) * pull two years worth of changes into release channel ([f5fb98d](f5fb98d)), closes [kalkih#1059](https://github.com/motorlatitude/mini-graph-card/issues/1059) * **attribute:** Retrieve an attribute instead of the state ([kalkih#564](https://github.com/motorlatitude/mini-graph-card/issues/564)) ([708bfde](708bfde)), closes [kalkih#411](https://github.com/motorlatitude/mini-graph-card/issues/411) [kalkih#245](https://github.com/motorlatitude/mini-graph-card/issues/245) [kalkih#501](https://github.com/motorlatitude/mini-graph-card/issues/501) * **graph:** Add median aggregate function ([kalkih#521](https://github.com/motorlatitude/mini-graph-card/issues/521)) ([57219bd](57219bd)) * **option:** override icon with an image URL ([kalkih#789](https://github.com/motorlatitude/mini-graph-card/issues/789)) ([2860a09](2860a09)) * Format numbers according to selected language [[kalkih#495](https://github.com/motorlatitude/mini-graph-card/issues/495) [kalkih#509](https://github.com/motorlatitude/mini-graph-card/issues/509)] ([5785bd8](5785bd8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix from #251 introduced a logic that
This caused aggregators to stop calculating proper results for that first group.
The proposed new logic drops out-of-bounds entries already in the reducer. This allows the first group to have multiple entries. Aggregate functions should now work again.
fixed #869