Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Fill thresholds (horizontal-banded gradient) #112

Closed
raffertyp1 opened this issue Jul 1, 2019 · 3 comments · Fixed by #152
Closed

Feature Request: Fill thresholds (horizontal-banded gradient) #112

raffertyp1 opened this issue Jul 1, 2019 · 3 comments · Fixed by #152
Labels
feature request New feature or request

Comments

@raffertyp1
Copy link

I saw that you had previously experimented with applying gradients to the fill, but ultimately decided against it (your post: https://community.home-assistant.io/t/lovelace-mini-graph-card/71385/184).

In that setup, the gradient changes were displayed as vertical bands (matched to x-axis values), which is why it may look a bit strange.

0c0329971b881b930e380f45c6f192080617b4ad

I'd like to request horizontal bands (matched to y-axis values) that mimics the line color thresholds. See the example below.

Chart-Gradient

If I was giving my full wishlist, I'd ask for an option to hide the line and only show the fill, but I'll open a separate issue for that :)

@raffertyp1
Copy link
Author

raffertyp1 commented Jul 1, 2019

As another example, here is a codepen that I forked with a simpler color scheme:
https://codepen.io/anon/pen/jjzWJq

canvas

@kalkih
Copy link
Owner

kalkih commented Jul 1, 2019

Yeah, I experimented with that prior to the rework of color thresholds (thresholds are now rendered along the Y-axis, instead of the x-axis).

Could give it another shot now when the thresholds are rendered differently, should work/look better.
Might be problematic when combined with the fill: fade option, can't guarantee it will work when used with that option.

Feel free to open another issue for the "hide line" request 👍

@kalkih kalkih added the feature request New feature or request label Jul 1, 2019
kalkih added a commit that referenced this issue Sep 18, 2019
* ✨ Fill adapting color_thresholds (#112)

* 💄 Obey fade option when gradient fill
@kalkih
Copy link
Owner

kalkih commented Oct 5, 2019

This is now available in the latest release 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants