Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defer attribute from polyfill script #237

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Remove defer attribute from polyfill script #237

merged 1 commit into from
Sep 5, 2022

Conversation

peeke
Copy link
Contributor

@peeke peeke commented Aug 31, 2022

In Node projecten wordt defer standaard op de polyfill script tag gezet in de polyfill functie. Op basis van https://kaliberinteract.slack.com/archives/C025GRZUL/p1661330729418279 denk ik dat we dit attribuut hier weg zouden moeten halen. Waarschijnlijk voegt dit wel wat latency toe aan onze websites.

@peeke peeke requested a review from EECOLOR August 31, 2022 12:01
EECOLOR
EECOLOR approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@EECOLOR EECOLOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! En qua latency denk ik dat het wel meevalt. Moderne browsers downloaden een leeg bestand van een CDN op een ander domein.

@peeke peeke merged commit 64e5e44 into master Sep 5, 2022
@peeke peeke deleted the polyfill-without-defer branch September 5, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EECOLOR EECOLOR EECOLOR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peeke @EECOLOR