Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lstm noprojection #23

Closed
wants to merge 3 commits into from
Closed

Lstm noprojection #23

wants to merge 3 commits into from

Conversation

naxingyu
Copy link
Contributor

Add LSTM component without projection.

@danpovey
Copy link
Contributor

Why are you putting the LSTM component stuff in the same pull request as your Maxout test code? For sure this will delay the merging of the code. Can we do this one issue at a time?

@naxingyu
Copy link
Contributor Author

Thanks Dan. Sorry for that. I thought github could distinguish pull requests from different commits... I close this request now.

@naxingyu naxingyu closed this Jul 24, 2015
@jtrmal
Copy link
Contributor

jtrmal commented Jul 24, 2015

It will... Buf you have to create the PRs from different branches. Then it
will work as expected.
y.

On Fri, Jul 24, 2015 at 7:41 PM, Xingyu Na notifications@github.com wrote:

Closed #23 #23.


Reply to this email directly or view it on GitHub
#23 (comment).

@naxingyu
Copy link
Contributor Author

Yes, I created a new branch, but the old commits are also in this new branch... I must have done something wrong, will figure it out.

@jtrmal
Copy link
Contributor

jtrmal commented Jul 24, 2015

I see... no, the unrelated commits have to be in separate branch :)
you can use git cherry-pick to pick the individual commits
http://stackoverflow.com/questions/25955822/git-cherry-pick-a-single-commit-for-pull-request

On Fri, Jul 24, 2015 at 7:48 PM, Xingyu Na notifications@github.com wrote:

Yes, I created a new branch, but the old commits are also in this new
branch... I must have done something wrong, will figure it out.


Reply to this email directly or view it on GitHub
#23 (comment).

@danpovey
Copy link
Contributor

or just wait till the first thing is committed.

On Fri, Jul 24, 2015 at 4:51 PM, jtrmal notifications@github.com wrote:

I see... no, the unrelated commits have to be in separate branch :)
you can use git cherry-pick to pick the individual commits

http://stackoverflow.com/questions/25955822/git-cherry-pick-a-single-commit-for-pull-request

On Fri, Jul 24, 2015 at 7:48 PM, Xingyu Na notifications@github.com
wrote:

Yes, I created a new branch, but the old commits are also in this new
branch... I must have done something wrong, will figure it out.


Reply to this email directly or view it on GitHub
#23 (comment).


Reply to this email directly or view it on GitHub
#23 (comment).

@naxingyu naxingyu deleted the lstm-noprojection branch July 25, 2015 03:16
david-ryan-snyder pushed a commit to david-ryan-snyder/kaldi that referenced this pull request Mar 8, 2016
Xvector: another update to nnet3-xvector-compute
galv pushed a commit to galv/kaldi that referenced this pull request Dec 10, 2022
Resolve "Rebase upstream 02/13/20"

Closes kaldi-asr#23

See merge request dl/dgx/kaldi!69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants