-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lstm noprojection #23
Conversation
Why are you putting the LSTM component stuff in the same pull request as your Maxout test code? For sure this will delay the merging of the code. Can we do this one issue at a time? |
Thanks Dan. Sorry for that. I thought github could distinguish pull requests from different commits... I close this request now. |
It will... Buf you have to create the PRs from different branches. Then it On Fri, Jul 24, 2015 at 7:41 PM, Xingyu Na notifications@github.com wrote:
|
Yes, I created a new branch, but the old commits are also in this new branch... I must have done something wrong, will figure it out. |
I see... no, the unrelated commits have to be in separate branch :) On Fri, Jul 24, 2015 at 7:48 PM, Xingyu Na notifications@github.com wrote:
|
or just wait till the first thing is committed. On Fri, Jul 24, 2015 at 4:51 PM, jtrmal notifications@github.com wrote:
|
Xvector: another update to nnet3-xvector-compute
Resolve "Rebase upstream 02/13/20" Closes kaldi-asr#23 See merge request dl/dgx/kaldi!69
Add LSTM component without projection.