Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore: add openfst 1.4.1 #1

Closed
wants to merge 1 commit into from
Closed

Conversation

amitbeka
Copy link
Contributor

Signed-off-by: Amit Beka amit.beka@gmail.com

Signed-off-by: Amit Beka <amit.beka@gmail.com>
@jtrmal
Copy link
Contributor

jtrmal commented May 12, 2015

Github repository is read-only. You should direct the patches directly to me (jtrmal@gmail.com), or to kaldi-developers@sourceforge.net

@jtrmal jtrmal closed this May 12, 2015
@kkm000
Copy link
Contributor

kkm000 commented Jul 8, 2015

@jtrmal: I do not know if it will prove extra work for you, but a PR is looking good, you can apply it in a single command. Just add the .diff extension to any commit or PR URL, and GitHub generates a diff from it. Try https://github.com/kaldi-asr/kaldi/pull/1.diff for this very request. :-)

In fact, I just did a couple minutes ago, from a clean sandbox' root

wget -qO- http://github.com/kaldi-asr/kaldi/commit/bba05342fa937371a8892eacd162941b83eac42a.diff | patch -p1

@jtrmal
Copy link
Contributor

jtrmal commented Jul 8, 2015

Interesting, but confusing -- I though I have already applied this patch a while ago. Let me check.
y.

@kkm000
Copy link
Contributor

kkm000 commented Jul 8, 2015

@jtrmal, I was talking about the process in general, not this particular patch. Sorry I have been unclear. What I meant was you can get the patch right off GitHub instead of directing the user to send it to you, and that is perhaps even easier.

@jtrmal
Copy link
Contributor

jtrmal commented Jul 8, 2015

Oh, I understand now. Thanks for making me realize this -- I saw the links
but it didn't occur to me to try it. Really fancy :)

On Wed, Jul 8, 2015 at 6:07 PM, Kirill Katsnelson notifications@github.com
wrote:

@jtrmal https://github.com/jtrmal, I was talking about the process in
general, not this particular patch. Sorry I have been unclear. What I meant
was you can get the patch right off GitHub instead of directing the user to
send it to you, and that is perhaps even easier.


Reply to this email directly or view it on GitHub
#1 (comment).

@amitbeka
Copy link
Contributor Author

amitbeka commented Jul 9, 2015

As an infrequent contributor to projects I find the github model easy to work with, and I think it will enable more small patches like this to be pushed, if github will be used.

@kkm000
Copy link
Contributor

kkm000 commented Jul 9, 2015

@amitbeka I am totally with you. Hope kaldi transitions soon : )

On the other hand, the guys are extremely--and I mean extremely extremely busy with the core speech recognition problems, and if you asked me about the priorities, I would rate the github transition somewhat lower.

@jtrmal
Copy link
Contributor

jtrmal commented Jul 10, 2015

Well, @amitbeka, feel free to use the git even now -- there is nothing
wrong with that. And if you are planning to submit the pull requests, the
svn "in the background" does not really affect you in any way :)
I myself am doing portion of the devleopment in github, just to get to
familiarize with it.
y.

On Thu, Jul 9, 2015 at 6:52 PM, Kirill Katsnelson notifications@github.com
wrote:

@amitbeka https://github.com/amitbeka I am totally with you. Hope kaldi
transitions soon : )

On the other hand, the guys are extremely--and I mean extremely extremely
busy with the core speech recognition problems, and if you asked me about
the priorities, I would rate the github transition somewhat lower.


Reply to this email directly or view it on GitHub
#1 (comment).

@amitbeka
Copy link
Contributor Author

Thanks!

On Fri, Jul 10, 2015 at 4:17 AM, jtrmal notifications@github.com wrote:

Well, @amitbeka, feel free to use the git even now -- there is nothing
wrong with that. And if you are planning to submit the pull requests, the
svn "in the background" does not really affect you in any way :)
I myself am doing portion of the devleopment in github, just to get to
familiarize with it.
y.

On Thu, Jul 9, 2015 at 6:52 PM, Kirill Katsnelson <
notifications@github.com>
wrote:

@amitbeka https://github.com/amitbeka I am totally with you. Hope
kaldi

transitions soon : )

On the other hand, the guys are extremely--and I mean extremely extremely
busy with the core speech recognition problems, and if you asked me about
the priorities, I would rate the github transition somewhat lower.


Reply to this email directly or view it on GitHub
#1 (comment).


Reply to this email directly or view it on GitHub
#1 (comment).

@jtrmal jtrmal mentioned this pull request Jul 22, 2015
danpovey referenced this pull request Aug 19, 2015
add Convolution component in nnet2
chenguoguo added a commit that referenced this pull request Oct 2, 2015
delete unnecessary code from the mikolov rnnlm code; made some stylis…
danpovey added a commit that referenced this pull request Dec 14, 2015
swap axis for optimization in Tensor3dCopy()
danpovey pushed a commit that referenced this pull request Apr 15, 2016
Add ivector support to online nnet3 decoder
danpovey pushed a commit that referenced this pull request Apr 17, 2016
creatorscan pushed a commit to creatorscan/kaldi that referenced this pull request Jun 14, 2016
creatorscan pushed a commit to creatorscan/kaldi that referenced this pull request Jun 14, 2016
change kaldi-asr#2
woooo, let's change the message a bit
hainan-xv referenced this pull request in hainan-xv/kaldi Jul 18, 2016
LvHang referenced this pull request in LvHang/kaldi Nov 28, 2016
LvHang referenced this pull request in LvHang/kaldi Nov 28, 2016
keli78 referenced this pull request in keli78/kaldi Jan 23, 2017
@danpovey danpovey mentioned this pull request Mar 7, 2017
Szu-JuiChen referenced this pull request in Szu-JuiChen/kaldi Jan 17, 2018
underdogliu referenced this pull request in underdogliu/kaldi Jul 11, 2018
LvHang referenced this pull request in LvHang/kaldi Aug 10, 2018
oplatek referenced this pull request in oplatek/kaldi Feb 8, 2019
davidavdav pushed a commit to davidavdav/kaldi that referenced this pull request Jun 8, 2019
[pykaldi] Provide access to the nnet posteriors
megazone87 pushed a commit to megazone87/kaldi that referenced this pull request Nov 22, 2019
daanzu added a commit to daanzu/kaldi that referenced this pull request Jun 26, 2020
ipmedenn pushed a commit to ipmedenn/kaldi that referenced this pull request Jul 19, 2020
paste-vectors and multiply-vectors fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants