Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rescoring Binary used #2834

Closed
ervaibhavkumar opened this issue Nov 13, 2018 · 5 comments
Closed

Incorrect rescoring Binary used #2834

ervaibhavkumar opened this issue Nov 13, 2018 · 5 comments

Comments

@ervaibhavkumar
Copy link
Contributor

Hi,

When i was running the script https://github.com/kaldi-asr/kaldi/blob/master/egs/ami/s5/local/tfrnnlm/run_vanilla_rnnlm.sh.

It was calling the wrong script for rescoring.
Should i proceed for a PR ?

Regards
Vaibhav

@danpovey
Copy link
Contributor

I'm still not sure, based on our email conversation, whether there was really a problem; please figure it out by email with Hainan and if there is a problem, make a PR. But I'm closing this issue in the interim-- please just make a PR if there was a problem.

@ervaibhavkumar
Copy link
Contributor Author

@danpovey I was talking about this in #2892

@danpovey
Copy link
Contributor

OK, you can go ahead and make a PR. We don't really use that setup much, but it would be good to have a fix.

@ervaibhavkumar
Copy link
Contributor Author

I will.
But can i know which setup you use ?

@danpovey
Copy link
Contributor

danpovey commented Nov 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants