Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global scope when referring to classes instead of local scope, avoiding conflicts with other gems #60

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

bogdanRada
Copy link
Contributor

Hello,

Thank you for this great gem. I was trying to use this gem with sprockets-helpers gem

And i found one issue , after requiring `sinatra/sprockets/helpers`` from that gem,
i received this error:

gems/sinatra-asset-pipeline-1.0.0/lib/sinatra/asset_pipeline.rb:7:in `registered': uninitialized constant Sinatra::Sprockets::Environment (NameError)

This fixes this issue. Let me know what you think. Thank you very much.

@kalasjocke
Copy link
Owner

@bogdanRada Do I understand this pull request correctly if I say that the sprockets-helpers gem define it's own Sprockets module which causes Sinatra::Sprockets::Environment to be undefined? If so, let's merge this one.

@bogdanRada
Copy link
Contributor Author

Yes, that is true :)

@kalasjocke
Copy link
Owner

@bogdanRada Great! Thanks for the pull request, merging.

@kalasjocke kalasjocke merged commit dbbb967 into kalasjocke:master Aug 24, 2016
@bogdanRada
Copy link
Contributor Author

Thank You very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants