Network/rnd icm refactoring #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ramanuzan
reviewed
Nov 22, 2021
jorldy/core/network/icm.py
Outdated
|
|
||
| self.bn1_next = torch.nn.BatchNorm1d(D_hidden) | ||
| self.bn1, self.bn2, self.bn1_next = mlp_batch_norm(D_hidden, feature_size) |
There was a problem hiding this comment.
self.batch_norm과 상관없이 해당 레이어들이 생성되는거 같아요.
아마 mlp_head 함수 때문인거 같은데요. mlp_head의 bn 들을 None으로 default로 잡아주고,
mlp_head를 self.batch_norm에 따라 다르게 실행하면 좋을 것 같습니다.
…to network/rnd_icm_refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 Hello! Thanks for contributing JORLDY!
Checklist
Please check if you consider the following items.
Types of changes
Please describe the types of changes! (ex. Bugfix, New feature, Documentation, ...)
Refactoring
Test Configuration
Description
Please describe the details of your contribution
RND and ICM networks are refactorized.