feat(all): add flags for logger #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2023
This was referenced May 16, 2023
This was referenced May 16, 2023
hungryjang
approved these changes
May 30, 2023
This PR adds common flags for logging to package `internal/flags`. Those flags include the followings: - `--logdir` - `--logtostderr` - `--logfile-max-backups` - `--logfile-retention-days` - `--logfile-max-size-mb` - `--logfile-name-utc` - `--logfile-compression` - `--log-human-readable` - `--loglevel` Those are very common. Hence all daemons can use them. Resolves #439
ijsong
force-pushed
the
mr_uncommit_report_pool
branch
from
fe4c70e to
4c624da
Compare
ijsong
force-pushed
the
common_logger_flags
branch
from
2218a40 to
7efe407
Compare
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds common flags for logging to package
internal/flags. Those flags include thefollowings:
--logdir--logtostderr--logfile-max-backups--logfile-retention-days--logfile-max-size-mb--logfile-name-utc--logfile-compression--log-human-readable--loglevelThose are very common. Hence all daemons can use them.
Which issue(s) this PR resolves
Resolves #439