Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the data directory when removing the log stream replica. #157

Closed
ijsong opened this issue Sep 20, 2022 · 0 comments · Fixed by #158 or #160
Closed

Remove the data directory when removing the log stream replica. #157

ijsong opened this issue Sep 20, 2022 · 0 comments · Fixed by #158 or #160
Assignees

Comments

@ijsong
Copy link
Member

ijsong commented Sep 20, 2022

The storage node does not delete the data directory when removing the log stream replica, and there is no particular reason not to remove it.
Not deleting the data directory has problems:

  • Re-joining replica that has not deleted data directory recovers too old data; then it will send report based on too old commit context.
  • It wastes disk space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant