Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithoutSync option does not work #102

Closed
ijsong opened this issue Aug 29, 2022 · 0 comments · Fixed by #103 or #105
Closed

WithoutSync option does not work #102

ijsong opened this issue Aug 29, 2022 · 0 comments · Fixed by #103 or #105
Assignees
@ijsong
Labels
bug Something isn't working

Comments

@ijsong
Copy link
Member

ijsong commented Aug 29, 2022

Current Behavior

The option internal/storage.WithoutSync does not work.

Expected Behavior

The sync operation of WAL should be deferred by using the option WithoutSync.

Steps To Reproduce

Environment

  • Varlog version: v0.2.2
  • OS:
  • Architecture:

Anything else
@ijsong ijsong added the bug Something isn't working label Aug 29, 2022
@ijsong ijsong self-assigned this Aug 29, 2022
ijsong added a commit that referenced this issue Aug 29, 2022
@ijsong
fix(storage): apply WithoutSync option correctly
2c25007 
Resolves #102
@ijsong ijsong mentioned this issue Aug 29, 2022
Merged
@ijsong ijsong mentioned this issue Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ijsong ijsong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ijsong