Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text of some errors #311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve text of some errors #311

wants to merge 3 commits into from

Commits on Oct 5, 2024

  1. Use MethodNotFoundErrorWithArg instead of MethodNotFoundError where p… 

    …ossible

Tests that need to be updated:

[info] - expr_unknown_method1 *** FAILED ***
[info]   [expr_unknown_method1.ksy: /instances/foo/value:
[info]          error: don't know how to call method 'frobnicate' of object type 'byte array'
[info]   ]
[info]     did not equal
[info]   [expr_unknown_method1.ksy: /instances/foo/value:
[info]          error: don't know how to call method 'frobnicate' of object type 'CalcBytesType'
[info]   ] (SimpleMatchers.scala:34)
[info] - expr_unknown_method2 *** FAILED ***
[info]   [expr_unknown_method2.ksy: /instances/foo/value:
[info]          error: don't know how to call method 'frobnicate' of object type 'byte array'
[info]   ]
[info]     did not equal
[info]   [expr_unknown_method2.ksy: /instances/foo/value:
[info]          error: don't know how to call method 'frobnicate' of object type 'CalcBytesType'
[info]   ] (SimpleMatchers.scala:34)
[info] - io_on_bytes *** FAILED ***
[info]   [io_on_bytes.ksy: /instances/one_in_foo/io:
[info]          error: don't know how to call method '_io' of object type 'byte array'
[info]   ]
[info]     did not equal
[info]   [io_on_bytes.ksy: /instances/one_in_foo/io:
[info]          error: don't know how to call method '_io' of object type 'BytesLimitType(IntNum(100),None,false,None,None)'
[info]   ] (SimpleMatchers.scala:34)
    @Mingun
    Mingun committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    e7721cb View commit details
    Browse the repository at this point in the history

  2. Introduce StreamType as base for OwnedKaitaiStreamType and KaitaiStre… 

    …amType
    @Mingun
    Mingun committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ed494ef View commit details
    Browse the repository at this point in the history

  3. Introduce StreamArg to better typecheck the io type

    @Mingun
    Mingun committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    9896a8a View commit details
    Browse the repository at this point in the history