Nested Subtypes

[hilts-vaughan]

Consider the following YAML type:

    seq:
      - id: frame_entry
        repeat: eos

        # The pages are always 512 byte blocks / pages
        # for some reason... not sure why considering a lot of
        # the data is wasted...
        size: 512

        types:
          junk:
            size: 174
          other:
            size: 338

It'd be nice if we could support the "subtypes", that is types within types. How is this done in Kaistruct today? Is everything top level?

[hilts-vaughan]

Forget me... I had it intended one level too shallow. :)

[LmpOSX]

Hi, I wonder if this is already implemented, or I'm using it the wrong way.
I'm trying to consolidate various individual ksy files into one file, and then calling those as subtypes, but I'm not getting the expected results at least under python. However using opaques, It works.
How should I use it, if it is implemented?

Follow is the example

File test1.ksy

meta:
  id: test1
  imports:
    - test2

seq:
  - id: test3
    type: test2::test3

I got the following python, no import test2, and no test2.Test3 neither

class Test1(KaitaiStruct):
    def __init__(self, _io, _parent=None, _root=None):
        self._io = _io
        self._parent = _parent
        self._root = _root if _root else self
        self._read()

    def _read(self):
        self.test3 = self._root.Test3(self._io, self, self._root)

However, if I use opaque-types as follows:

File test1.ksy

meta:
  id: test1
  ks-opaque-types: true

seq:
  - id: test3
    type: test2::test3

Then python code is:

import test2
class Test1(KaitaiStruct):
    def __init__(self, _io, _parent=None, _root=None):
        self._io = _io
        self._parent = _parent
        self._root = _root if _root else self
        self._read()

    def _read(self):
        self.test3 = test2.self._root.Test3(self._io)

[KOLANICH]

Unfortuantely the addressing scheme is contoversal. Enums and their values names are separated with ::, but types and subtypes are separated with .

[GreyCat]

@LmpOSX This is a new bug report, I've split it into separate issue. Let's continue there.

@KOLANICH Please don't leave misleading comments. type: test2::test3 is perfectly correct and valid.

[KOLANICH]

I just remembered the discussion in #452.

BTW, #487, #275, are they fixed?