Bulk 2021 04 11 #480
Merged
Bulk 2021 04 11 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeehoonkang
commented
Apr 10, 2021
jeehoonkang
commented
- PR이 좀 큰데 대부분 파일 옮긴거라 일단 한번 올려봅니다.
- 혹시 쪼개서 review해야할 필요가 있다면 알려주세요.
Medowhill
reviewed
Apr 12, 2021
Medowhill
approved these changes
Apr 12, 2021
travis1829
suggested changes
Apr 12, 2021
| @@ -36,7 +26,7 @@ impl<'s, R: RawLock, U, T> RemoteLock<'s, R, U, T> { | |||
| /// | |||
| /// ```rust,no_run | |||
| /// let spinlock: Spinlock<usize> = Spinlock::new("spinlock", 10); | |||
| /// let spinlock_protected: RemoteSpinlock<'_, usize, isize> = RemoteLock::new(&spinlock, -20); | |||
| /// let spinlock_remote: RemoteSpinlock<'_, usize, isize> = RemoteLock::new(&spinlock, -20); | |||
There was a problem hiding this comment.
RemoteSpinlock라는 type alias가 없어진 것 같은데, 그러면 이 example도 다음과 같이 바꿔야될 것 같습니다.
/// let spinlock_remote: RemoteLock<'_, RawSpinlock, usize, isize> = RemoteLock::new(&spinlock, -20);
There was a problem hiding this comment.
이 부분은 다른 PR에서 제가 처리하도록 하겠습니다.
|
bors r+ |
|
Build succeeded: |
Merged
kaist-cp-bors bot
added a commit
that referenced
this pull request
Apr 12, 2021
484: Small fix r=Medowhill a=travis1829 매우 간단한 PR입니다. 바로 merge해주셔도 될 것 같습니다. * Fix for #480 (comment) * Fix for #469 (comment) * rustfmt version이 1.4.36-nightly로 업데이트되어, 더 이상 `#[rustfmt::skip]`을 붙일 필요가 없습니다. Co-authored-by: travis1829 <travis1829@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.