Unsafe reasoning in ArrayArena #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeehoonkang
reviewed
Jan 27, 2021
Medowhill
commented
Jan 27, 2021
Medowhill
commented
Jan 27, 2021
Medowhill
changed the title
jeehoonkang
requested changes
Feb 1, 2021
jeehoonkang
approved these changes
Feb 2, 2021
| unsafe { (*handle.ptr).refcnt += 1 }; | ||
| Self::Handle { | ||
| // It is safe becuase of the invariant of ArrayPtr. | ||
| unsafe { (*handle.ptr.as_ptr()).refcnt += 1 }; |
There was a problem hiding this comment.
아주 사소한건데 ... += 1; 이렇게 가는게 어떨까 합니다
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arena의 unsafe reasoning을 위한 PR입니다.일단ArrayPtr과MruPtr이 가지고 있는 포인터를*mut에서NonNull로 바꾸었습니다.코드를 보다 보니Arena구현에 관련된 질문이 몇 가지 생겼는데 해당 위치에 comment로 달아 두겠습니다.edited
ArrayArena의 unsafe reasoning을 위한 PR입니다.ArrayPtr과MruPtr이 가지고 있는 포인터를*mut에서NonNull로 바꾸었습니다.impl<A: Arena, T: Clone + Deref<Target = A>> Arena for T를 없애고Arena트레잇에Rc를 반환하는 메서드를 추가했습니다.ArrayPtr이 해당 핸들을 만든ArrayArena가 살아 있는 동안만 살아 있도록ArrayPtr에 lifetime parameter를 추가했습니다. 이에 따라Rc에도 lifetime parameter가 추가되었습니다.MruArena는 이 PR에서 다루지 않습니다.