Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k0s artifacts #3193

Merged
merged 13 commits into from
Feb 14, 2025
Merged

Add k0s artifacts #3193

merged 13 commits into from
Feb 14, 2025

Conversation

mauromorales
Copy link
Member

fixes #3157

Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
@mauromorales mauromorales marked this pull request as ready for review February 14, 2025 12:26
@mauromorales mauromorales requested a review from a team February 14, 2025 12:26
@mauromorales mauromorales self-assigned this Feb 14, 2025
Copy link
Contributor

@jimmykarily jimmykarily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no better way to see if it works than to run it :D

@mauromorales
Copy link
Member Author

@jimmykarily i did run on the pr once just to be sure at least that one produces a working image ... but yeah master and release are always a gamble :P

IMAGE_NAME="quay.io/kairos/ci-temp-images:${{ steps.split.outputs.flavor }}-${{ steps.split.outputs.flavor_release }}-${{ inputs.variant }}-${{ inputs.arch }}"
# Add kubernetes_distro and kubernetes_version if they are set
if [[ -n "${{ inputs.kubernetes_distro }}" ]]; then
IMAGE_NAME+="-${{ inputs.kubernetes_distro }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh this is nice, maybe put it on the release reusable as well? Very nice

@Itxaka
Copy link
Member

Itxaka commented Feb 14, 2025

notice that we dont push to a fixed place anymore to waste time. Temp images can be found at https://quay.io/repository/kairos/ci-temp-images?tab=tags&tag=latest but they expire after 6 hours. Master builds are no longer pushed to a fixed place as well, no point into that when its that easy to build your own one :D

@Itxaka
Copy link
Member

Itxaka commented Feb 14, 2025

@jimmykarily i did run on the pr once just to be sure at least that one produces a working image ... but yeah master and release are always a gamble :P

mmmmh I take issue with that 😭

Signed-off-by: Mauro Morales <contact@mauromorales.com>
Signed-off-by: Mauro Morales <contact@mauromorales.com>
@mauromorales mauromorales merged commit 217bb28 into master Feb 14, 2025
49 of 51 checks passed
@mauromorales mauromorales deleted the add-k0s-artifacts branch February 14, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: Add k0s artifacts to the pipeline
3 participants