Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix agent not able to get subkeys #1299

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Apr 14, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1297

@Itxaka Itxaka requested a review from a team April 14, 2023 13:39
@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for kairos-io ready!

Name Link
🔨 Latest commit 90a0af8
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/64397585b09ee60008e94240
😎 Deploy Preview https://deploy-preview-1299--kairos-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #1299 (90a0af8) into master (7bb9af9) will decrease coverage by 1.66%.
The diff coverage is 45.16%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   22.79%   21.13%   -1.66%     
==========================================
  Files          22       16       -6     
  Lines        1610     1282     -328     
==========================================
- Hits          367      271      -96     
+ Misses       1179      960     -219     
+ Partials       64       51      -13     
Impacted Files Coverage Δ
internal/agent/config.go 0.00% <ø> (ø)
internal/agent/interactive_install.go 0.00% <ø> (ø)
internal/agent/notify.go 0.00% <0.00%> (ø)
internal/agent/recovery.go 0.00% <ø> (ø)
internal/agent/reset.go 0.00% <0.00%> (ø)
internal/agent/upgrade.go 0.00% <0.00%> (ø)
pkg/config/config.go 0.00% <0.00%> (-51.36%) ⬇️
internal/agent/install.go 5.10% <21.21%> (+5.10%) ⬆️
pkg/config/collector/options.go 64.51% <37.50%> (ø)
pkg/config/collector/collector.go 61.13% <61.13%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mudler mudler merged commit 3980bf1 into kairos-io:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 config get fails to fetch deep nested keys
4 participants