Update cloud config and add partitions config #59
Conversation
Updates the cloud config page with all the now possible values to override th default configs, now that ythe full config and spec is read from the cloud-config via the agent. Also adds a page on how to specifically configure the current partitions during install and add extra partitions during install Signed-off-by: Itxaka <itxaka@kairos.io>
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Itxaka <itxaka@kairos.io>
| @@ -22,6 +22,14 @@ users: | |||
| ssh_authorized_keys: | |||
| # - github:mudler | |||
|
|
|||
| # enable debug logging | |||
| debug: true | |||
There was a problem hiding this comment.
After the merging of all configs, does the schema need an update? https://github.com/kairos-io/kairos-sdk/tree/main/schema
There was a problem hiding this comment.
Good point! I remember updating it already so it would pass the tests. Not sure if the tests are now broken or it's not necessary anymore...
Gonna check
| ``` | ||
|
|
||
|
|
||
| Note that there are some caveats in the `extra partitions` setup: |
There was a problem hiding this comment.
Shouldn't we also mention that if they try to override the labels of the default partitions, these will be ignored? (as per the PR here: https://github.com/kairos-io/kairos-agent/pull/108/files)
There was a problem hiding this comment.
Not really no, the label stuff is for the system partitions and its mentioned above that we only support fs and size overrides.
There was a problem hiding this comment.
I dont want to give them ideas that they can indeed override the labels lol, security through obscurity
Updates the cloud config page with all the now possible values to override th default configs, now that ythe full config and spec is read from the cloud-config via the agent.
Also adds a page on how to specifically configure the current partitions during install and add extra partitions during install
Fixes: kairos-io/kairos#558