Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1114 enclave cc #37

Merged
merged 1 commit into from
Mar 27, 2023
Merged

1114 enclave cc #37

merged 1 commit into from
Mar 27, 2023

Conversation

jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily self-assigned this Mar 23, 2023
mudler
mudler approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here, there are few improvements, but we can address later as it is already a good starting point!

@mudler
Copy link
Member

mudler commented Mar 24, 2023

Note: you need to add it in the workflow files, or it won't build any image

@mudler
Copy link
Member

mudler commented Mar 24, 2023

Here

community-bundles/.github/workflows/publish.yaml

Line 21 in 07a32a5

bundles:

@jimmykarily
Add coco bundle
9864e1d 
This bundle requires some manual steps (TODO: docs) to get confidential
workloads to run. There are also various improvements, some of them will
require upstream (k3s or confidential-containers) changes.

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily merged commit dad64e6 into main Mar 27, 2023
@jimmykarily jimmykarily deleted the 1114-enclave-cc branch March 27, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees

@jimmykarily jimmykarily

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmykarily @mudler