Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minor Version Maven Dependencies #397

Merged
merged 21 commits into from
Apr 22, 2024

Conversation

thewriteway
Copy link

List of version changes and success status:
image
Regression fixes included.

dependabot bot and others added 13 commits March 18, 2024 09:58
Bumps [org.apache.maven.plugins:maven-jxr-plugin](https://github.com/apache/maven-jxr) from 3.0.0 to 3.3.2.
- [Release notes](https://github.com/apache/maven-jxr/releases)
- [Commits](apache/maven-jxr@jxr-3.0.0...jxr-3.3.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-jxr-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
dependency regression fixing
Bumps [org.apache.maven.plugins:maven-jxr-plugin](https://github.com/apache/maven-jxr) from 3.0.0 to 3.3.2.
- [Release notes](https://github.com/apache/maven-jxr/releases)
- [Commits](apache/maven-jxr@jxr-3.0.0...jxr-3.3.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-jxr-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
dependency regression fixing
@thewriteway
Copy link
Author

thewriteway commented Apr 1, 2024

Hi Kagemomiji, I tried to update as many minor dependencies as possible in this PR. I cant tell if the build tests are too sensitive or if my PR code isn't compatible enough.

Copy link
Owner

@kagemomiji kagemomiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewriteway

Thank you for submitting the updates.

Upon reviewing the CI errors, it appears to be an issue related to logback dependencies, so I believe that changing the logback version is the direct cause of the error.
I have also commented on other changes that need to be made.

airsonic-main/pom.xml Outdated Show resolved Hide resolved
airsonic-main/pom.xml Outdated Show resolved Hide resolved
airsonic-main/pom.xml Outdated Show resolved Hide resolved
airsonic-main/pom.xml Outdated Show resolved Hide resolved
airsonic-main/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
thewriteway and others added 8 commits April 12, 2024 09:43
Co-authored-by: Y.Tory <5343692+kagemomiji@users.noreply.github.com>
Co-authored-by: Y.Tory <5343692+kagemomiji@users.noreply.github.com>
Co-authored-by: Y.Tory <5343692+kagemomiji@users.noreply.github.com>
Co-authored-by: Y.Tory <5343692+kagemomiji@users.noreply.github.com>
Co-authored-by: Y.Tory <5343692+kagemomiji@users.noreply.github.com>
Co-authored-by: Y.Tory <5343692+kagemomiji@users.noreply.github.com>
@thewriteway thewriteway requested a review from kagemomiji April 22, 2024 09:32
Copy link
Owner

@kagemomiji kagemomiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kagemomiji kagemomiji merged commit 6304922 into kagemomiji:main Apr 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants