Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brokers: Improve accessibility for r/o clusters #556

Merged

Conversation

hadisfr
Copy link
Contributor

@hadisfr hadisfr commented Sep 21, 2024

  • Breaking change?

What changes did you make? (Give an overview)
There are some inconsistencies between the backend and frontend in the case of read-only clusters.
This results in enabled buttons which if you click them, get 405 error.
This PR tries to make them consistent.

There may be still some inconsistencies in the ACL page.
I can not check or fix them now, because I have no running kafka cluster with authentication/ACL enabled.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@hadisfr hadisfr requested review from a team as code owners September 21, 2024 14:57
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 21, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024
@hadisfr hadisfr force-pushed the feature/integrate_readonly_cluster_restrictions branch from 6b4450d to 77da344 Compare September 21, 2024 14:57
@hadisfr hadisfr changed the title FE Integrate readonly cluster restrictions EH: Integrate read-only cluster restrictions Sep 21, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 21, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 25, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 25, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 28, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 28, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 28, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 28, 2024
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 28, 2024
@hadisfr hadisfr force-pushed the feature/integrate_readonly_cluster_restrictions branch from 304c880 to 5e5f9e4 Compare September 28, 2024 15:30
hadisfr added a commit to hadisfr/kafka-ui that referenced this pull request Sep 28, 2024
@hadisfr hadisfr force-pushed the feature/integrate_readonly_cluster_restrictions branch from 5e5f9e4 to bec34c5 Compare September 28, 2024 15:46
@Haarolean Haarolean self-requested a review September 28, 2024 16:13
@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Sep 28, 2024
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes area/brokers Broker / broker configs related issues labels Sep 28, 2024
@Haarolean Haarolean self-assigned this Sep 28, 2024
@Haarolean Haarolean added this to the 1.1 milestone Sep 28, 2024
@Haarolean Haarolean changed the title EH: Integrate read-only cluster restrictions Brokers: Improve accessibility for r/o clusters Sep 28, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
@Haarolean Haarolean merged commit 8d742ba into kafbat:main Oct 16, 2024
36 of 37 checks passed
@Haarolean
Copy link
Member

@hadisfr thank you for your first contribution to kafbat UI!

@hadisfr
Copy link
Contributor Author

hadisfr commented Oct 16, 2024

@hadisfr thank you for your first contribution to kafbat UI!

Thank you for your help and effort @Haarolean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/brokers Broker / broker configs related issues hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants