-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brokers: Improve accessibility for r/o clusters #556
Merged
Haarolean
merged 4 commits into
kafbat:main
from
hadisfr:feature/integrate_readonly_cluster_restrictions
Oct 16, 2024
Merged
Brokers: Improve accessibility for r/o clusters #556
Haarolean
merged 4 commits into
kafbat:main
from
hadisfr:feature/integrate_readonly_cluster_restrictions
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 21, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 21, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 21, 2024
6b4450d
to
77da344
Compare
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 21, 2024
Haarolean
requested changes
Sep 23, 2024
api/src/main/java/io/kafbat/ui/controller/BrokersController.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/controller/BrokersController.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/kafbat/ui/controller/BrokersController.java
Outdated
Show resolved
Hide resolved
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 25, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 25, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 28, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 28, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 28, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 28, 2024
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 28, 2024
304c880
to
5e5f9e4
Compare
hadisfr
added a commit
to hadisfr/kafka-ui
that referenced
this pull request
Sep 28, 2024
Co-authored-by: Roman Zabaluev <gpg@haarolean.dev>
5e5f9e4
to
bec34c5
Compare
Haarolean
reviewed
Sep 28, 2024
frontend/src/components/Brokers/Broker/Configs/TableComponents/InputCell/styled.ts
Show resolved
Hide resolved
Haarolean
approved these changes
Oct 15, 2024
@hadisfr thank you for your first contribution to kafbat UI! |
Thank you for your help and effort @Haarolean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/brokers
Broker / broker configs related issues
hacktoberfest-accepted
PRs accepted towards hacktoberfest goal and will be counted as approved
scope/backend
Related to backend changes
scope/frontend
Related to frontend changes
status/triage/completed
Automatic triage completed
type/enhancement
En enhancement/improvement to an already existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
There are some inconsistencies between the backend and frontend in the case of read-only clusters.
This results in enabled buttons which if you click them, get 405 error.
This PR tries to make them consistent.
There may be still some inconsistencies in the ACL page.
I can not check or fix them now, because I have no running kafka cluster with authentication/ACL enabled.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)