Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pact as a dependency #186

Merged
merged 9 commits into from
May 1, 2024
Merged

Remove pact as a dependency #186

merged 9 commits into from
May 1, 2024

Conversation

emmanueldenloye
Copy link
Contributor

We only seemed to need it for generating the richlist. This is a lot easier than I had imagined.

We only seemed to need it for generating the richlist.
This is a lot easier than I had imagined.
@enobayram
Copy link
Contributor

Oh wow, this is such a relief. This should relax our dependency resolution quite a bit while upgrading our GHC or Hackage index. Thank you for the PR!

BTW, would you mind checking how much further we can slim down the cabal.project? Now that pact is gone, I have a suspicion that the vast majority of that file's contents can be deleted.

@enobayram enobayram mentioned this pull request Apr 30, 2024
@enobayram
Copy link
Contributor

Seems like installing xz and postgresql inside the non-Nix MacOS CI fixed the build, so let's keep the non-Nix macos-latest builds for now. But since we already have the Nix builds on macos-latest (and also macos-m1), let's drop support for the non-Nix macos-latest build next time it causes issues. If somebody needs chainweb-data on macos and they don't want the nix-built version for some reason, it shouldn't be too hard for them to figure out how to set up their local environment in order to build it with cabal.

As a measure to make non-Nix builds more stable since we're removing the freeze file.
@enobayram
Copy link
Contributor

I've just added index-state: 2024-02-01T00:00:00Z to the cabal.project since we're removing the cabal.project.freeze file. I'm hoping this will be a more future-proof way of maintaining consistent and stable builds inside and outside Nix.

With my latest commits, in addition to these CI builds, cabal build chainweb-data works:

  • Ubuntu; Outside Nix using cabal and ghc provisioned with ghcup

  • Ubuntu: Inside nix develop

  • MacOS: Outside Nix using cabal and ghc provisioned with ghcup, installing xz and postgresql via homebrew and using the following cabal.project.local file:

      package *
        extra-include-dirs:
            /opt/homebrew/include
            /opt/homebrew/opt/openssl/include
        extra-lib-dirs:
            /opt/homebrew/lib
            /opt/homebrew/opt/openssl/lib
    
  • MacOS: Inside nix develop.

Copy link
Contributor

@enobayram enobayram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for removing the pact dependency @emmanueldenloye, this should make chainweb-data much easier to update in the future.

@enobayram enobayram merged commit 13ee540 into master May 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants