crossChainAccount derivation improvements for /txs/account #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the derivation of the
crossChainAccount
(andcrossChainId
) information for cross-chain transfers served by the/txs/account
endpoint.:TRANSFER
and theTRANSFER_XCHAIN
events. The check is redundant and it's fragile due to the volatility of decimal representations.X_RESUME
event on the receiving transaction as the data source, instead of theTRANSFER_XCHAIN
event on the sending transaction. This has 2 benefits: It allows us to remove the amount check due to the same reasons, and it avoids relying on the data from an independent block being present.Special thanks to @Takadenoshi for identifying this issue, helping me analyze it and suggesting the fix involving the
X_RESUME
event!