Fill command diagnostics #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enobayram
suggested changes
Jul 14, 2023
Co-authored-by: Enis Bayramoğlu <enisbayramoglu@gmail.com>
…-io/chainweb-data into emmanuel/fill-command-diagnostics
Co-authored-by: Enis Bayramoğlu <enisbayramoglu@gmail.com>
Co-authored-by: Enis Bayramoğlu <enisbayramoglu@gmail.com>
enobayram
approved these changes
Jul 18, 2023
Co-authored-by: Enis Bayramoğlu <enisbayramoglu@gmail.com>
Co-authored-by: Enis Bayramoğlu <enisbayramoglu@gmail.com>
Co-authored-by: Enis Bayramoğlu <enisbayramoglu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed that while attempting to fill gaps (missing rows in each table) in the database, that gaps would still remain.
We noticed upon further inspection that we were accessing the block header and payload endpoints incorrectly. Both can be accessed via chainweb-node's P2P API, however, it is only possible to get back at most 20 items and we had previously assumed we would always retrieve 360 items. We simply had to make sure to use chainweb-node's service API.
We also noticed another small error in the way gaps were being calculated. Even with a full db, chainweb-data would proclaim that it had gaps of size 0 at the genesis block of chain.