Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #437 - deploy snapshots #544

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Closes #437 - deploy snapshots #544

merged 6 commits into from
Feb 13, 2025

Conversation

bruderj15
Copy link
Member

@bruderj15 bruderj15 commented Feb 7, 2025 •
edited
Loading

Thanks for your PR! Please fill out the following list :)

  • I put the ticket or multiple tickets in review
  • Commit message format → Closes #<Issue Number> - Your commit message.
  • Sonarcloud link : https://github.com/kadai-io/kadai/runs/37128318084
  • No documentation update needed
  • Link to PR with documentation update: <add the link here>
  • No Release Notes needed
  • Release Notes :

@bruderj15
Copy link
Member Author

Keep this PR for testing, see discussion at #548 (comment).

@bruderj15 bruderj15 added the github_actions Pull requests that update GitHub Actions code label Feb 11, 2025
@bruderj15 bruderj15 marked this pull request as ready for review February 12, 2025 22:07
@bruderj15
Copy link
Member Author

Resolved the issue together with the Central Support.
There was a problem on their side.
Thanks!

@bruderj15 bruderj15 changed the title Closes #437 - temporarily deploy snapshot on PR for debugging 403 error Closes #437 - deploy snapshots Feb 12, 2025
CRoberto1926
CRoberto1926 reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@CRoberto1926 CRoberto1926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you revert all of our previous attempts, so that pom and pipeline are clean?

@bruderj15
Copy link
Member Author

Did you revert all of our previous attempts, so that pom and pipeline are clean?

They have been previously removed with #548.
All changes here are as if we never experimented in the first way.

CRoberto1926
CRoberto1926 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@CRoberto1926 CRoberto1926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do the same in KadaiAdapter, or at least create an issue for this? Thanks!

@bruderj15
Copy link
Member Author

Could you please do the same in KadaiAdapter, or at least create an issue for this? Thanks!

Issue already exists: kadai-io/KadaiAdapter#66
Will implement soon.

@bruderj15 bruderj15 merged commit 21a50e8 into master Feb 13, 2025
78 checks passed
@bruderj15 bruderj15 deleted the revert-65-KAD-64 branch February 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRoberto1926 CRoberto1926 CRoberto1926 approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruderj15 @CRoberto1926