Clarify exhaustiveCheck

kachick · Jun 7, 2024 · 7f7c776 · 7f7c776
1 parent fc3c525
commit 7f7c776
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 16 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -32416,13 +32416,18 @@ function matchPath({ workflowFile, jobName, jobMatchMode }, summary) {
   if (!jobName) {
     return true;
   }
-  if (jobMatchMode === "exact") {
-    return jobName === summary.jobName;
-  }
-  if (jobMatchMode === "prefix") {
-    return summary.jobName.startsWith(jobName);
+  switch (jobMatchMode) {
+    case "exact": {
+      return jobName === summary.jobName;
+    }
+    case "prefix": {
+      return summary.jobName.startsWith(jobName);
+    }
+    default: {
+      const _exhaustiveCheck = jobMatchMode;
+      return false;
+    }
   }
-  return false;
 }
 function seekWaitList(summaries, waitList, elapsed) {
   const seeker = waitList.map((condition) => ({ ...condition, found: false }));
@@ -32579,7 +32584,7 @@ function colorize(severity, message) {
       return message;
     }
     default: {
-      const _unexpectedSeverity = severity;
+      const _exhaustiveCheck = severity;
       return message;
     }
   }

diff --git a/src/main.ts b/src/main.ts
@@ -16,7 +16,7 @@ function colorize(severity: Severity, message: string): string {
       return message;
     }
     default: {
-      const _unexpectedSeverity: never = severity;
+      const _exhaustiveCheck: never = severity;
       return message;
     }
   }

diff --git a/src/report.ts b/src/report.ts
@@ -93,15 +93,18 @@ function matchPath({ workflowFile, jobName, jobMatchMode }: FilterCondition, sum
     return true;
   }
 
-  if (jobMatchMode === 'exact') {
-    return jobName === summary.jobName;
-  }
-
-  if (jobMatchMode === 'prefix') {
-    return summary.jobName.startsWith(jobName);
+  switch (jobMatchMode) {
+    case 'exact': {
+      return jobName === summary.jobName;
+    }
+    case 'prefix': {
+      return summary.jobName.startsWith(jobName);
+    }
+    default: {
+      const _exhaustiveCheck: never = jobMatchMode;
+      return false;
+    }
   }
-
-  return false;
 }
 
 function seekWaitList(