Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide special parser for original Crockford's base32 possibility #78

Closed
kachick opened this issue May 4, 2021 · 2 comments · Fixed by #206
Closed

Provide special parser for original Crockford's base32 possibility #78

kachick opened this issue May 4, 2021 · 2 comments · Fixed by #206
Labels
enhancement New feature or request

Comments

@kachick
Copy link
Owner

kachick commented May 4, 2021

ref: #57 and ulid/spec#57

My suggestion around the issue is written in oklog/ulid#69 (comment) and https://github.com/ulid/spec/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R31

All characters except 0123456789ABCDEFGHJKMNPQRSTVWXYZabcdefghjkmnpqrstvwxyz are invalid in ULID

I think ignoring them is the desirable spec for actual use-case, rather than strict following original Crockford's base32.

But providing the parser for covering the original Crockford's base32 might be useful for exists difficult ULIDs.

How

  • When provide to it, the parser should have another name with current one, I feel 🤔
@kachick kachick added the enhancement New feature or request label May 4, 2021
@kachick
Copy link
Owner Author

kachick commented May 4, 2021

When provide to it, the parser should have another name with current one, I feel 🤔

Or adding keyword arguments as an optional parameter? 🤔

@kachick
Copy link
Owner Author

kachick commented May 4, 2021

Just providing new parser is not a hard task. Considering to update or keep exists methods is annoy 🤔

  • ULID.valid?
  • ULID.scan
  • ULID#===
  • ULID#pattern
  • ULID#strict_pattern

@kachick kachick changed the title Provide special parser for strict Crockford's base32 specs Provide special parser for original Crockford's base32 possibility May 5, 2021
kachick added a commit that referenced this issue May 17, 2021
Resolves #150

This is a simple solution for following issues

* #78
* #57
* #143
* ulid/spec#57
* ulid/spec#3
kachick added a commit that referenced this issue Jul 3, 2022
Closes #143
Resolves #57
Resolves #78
Updates #205 (Renamed non released method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant