Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot send anything to google lens Infinite spinner. Also the selection curor is invisible on some sites. #6

Closed
mzso opened this issue Sep 28, 2023 · 7 comments

Comments

@mzso
Copy link

mzso commented Sep 28, 2023

I guess the mean functionality plainly just broke, probably by a change from google. Never goes beyond the "Uploading image..." message.

Also selection can be rather annoying because, the cursor becomes invisible. Perplexingly on pages with white backgrounds, which is the most common appearance...
Random example: https://floravita.superwebaruhaz.hu/

kabuspl added a commit that referenced this issue Sep 28, 2023
@kabuspl
Copy link
Owner

kabuspl commented Sep 28, 2023

Fixed. I didn't notice the invisible cursor on white backgrounds because I use dark mode. Thanks for the report!

@kabuspl kabuspl closed this as completed Sep 28, 2023
@mzso
Copy link
Author

mzso commented Sep 29, 2023

@kabuspl commented on Sep 28, 2023, 4:34 PM GMT+2:

Fixed. I didn't notice the invisible cursor on white backgrounds because I use dark mode. Thanks for the report!

Originally posted by @kabuspl in #6 (comment)

Great. I can verify that it works now.

I wonder what you mean by dark mode though? My OS and FF instance does use dark theme as well. But light webpages are light of course.

@mzso
Copy link
Author

mzso commented Sep 29, 2023

However I observe some submissings getting stuck uploading. Potentially infinitely.
This submission (I don't know if it appears appropriately) got stock for a minute or so (with an almost itentical submission) until a I searched for a smaller image. Trying it a third time it got stock forever apparently. For the third time it got stuck for several minutes. 4-7 minutes, until I almost got finished typing this comment. I tried refreshing a couple times during the wait, but it had no effect.

It's a mere screenshot of this video.

@kabuspl
Copy link
Owner

kabuspl commented Oct 2, 2023

@kabuspl commented on Sep 28, 2023, 4:34 PM GMT+2:

Fixed. I didn't notice the invisible cursor on white backgrounds because I use dark mode. Thanks for the report!
Originally posted by @kabuspl in #6 (comment)

Great. I can verify that it works now.

I wonder what you mean by dark mode though? My OS and FF instance does use dark theme as well. But light webpages are light of course.

I have DarkReader extension that turns all light websites dark.

@kabuspl
Copy link
Owner

kabuspl commented Oct 2, 2023

However I observe some submissings getting stuck uploading. Potentially infinitely. This submission (I don't know if it appears appropriately) got stock for a minute or so (with an almost itentical submission) until a I searched for a smaller image. Trying it a third time it got stock forever apparently. For the third time it got stuck for several minutes. 4-7 minutes, until I almost got finished typing this comment. I tried refreshing a couple times during the wait, but it had no effect.

It's a mere screenshot of this video.

I will take a look at it. I was able to reproduce it.

@kabuspl kabuspl reopened this Oct 2, 2023
@mzso
Copy link
Author

mzso commented Jan 1, 2024

This is still very common. Often it gets stuck on loading.
Sometimes it gets unstuck if I search for another screenshot. And both are sent simultaneously. (usually about the same thing)

@kabuspl kabuspl closed this as completed in f8a6d73 Jan 1, 2024
@kabuspl
Copy link
Owner

kabuspl commented Jan 1, 2024

I found a way to fix this. For some reason, Google's server sometimes has a problem with PNG files sent by this extension. I changed the code to send WEBP files instead and now it always works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants