Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to compile more than one string #44

Closed
k94ll13nn3 opened this issue Sep 5, 2017 · 1 comment
Closed

Add possibility to compile more than one string #44

k94ll13nn3 opened this issue Sep 5, 2017 · 1 comment
Labels
breaking enhancement
Milestone
4.0

Comments

@k94ll13nn3
Copy link
Owner

k94ll13nn3 commented Sep 5, 2017 •
edited
Loading

The current compile API will be removed.

  • Change Compile(string input) to return a CompiledString
  • Overload Resolve with a Resolve(CompiledString input, T value) method (this will make call with a null string ambiguous)
  • Add a CompiledString sealed class with only one public member: the original input
k94ll13nn3 added a commit that referenced this issue Sep 7, 2017
@k94ll13nn3
Mark current compile API as obsolete
aa4072f 
See #44
Add new API methods signature
k94ll13nn3 added a commit that referenced this issue Sep 14, 2017
@k94ll13nn3
Revert "Mark current compile API as obsolete"
7db247d 
This reverts commit aa4072f.
See #44: changes to the compile API will be breaking changes, so it is
paused for now.
@k94ll13nn3
Copy link
Owner Author

Paused until 4.0 dev is started.

@k94ll13nn3 k94ll13nn3 mentioned this issue Oct 14, 2017
Closed
@k94ll13nn3 k94ll13nn3 added this to the 4.0 milestone Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@k94ll13nn3