Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

fix(config): set default host value to '0.0.0.0' #55

Merged
merged 2 commits into from
May 7, 2019

Conversation

CoderChang65535
Copy link
Contributor

@CoderChang65535 CoderChang65535 commented May 7, 2019

Closes #54
set default host value from localhost to 0.0.0.0.

@codecov-io
Copy link

Codecov Report

Merging #55 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #55   +/-   ##
==========================================
  Coverage      84.73%   84.73%           
  Complexity       468      468           
==========================================
  Files             67       67           
  Lines           1448     1448           
==========================================
  Hits            1227     1227           
  Misses           221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3997d23...563763e. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented May 7, 2019

Code Climate has analyzed commit 563763e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.0% (0.0% change).

View more on Code Climate.

@k911 k911 merged commit 2c9221d into k911:develop May 7, 2019
@k911
Copy link
Owner

k911 commented May 7, 2019

Thanks @CoderChang65535

@CoderChang65535
Copy link
Contributor Author

@k911 You are welcome and that is my pleasure.

k911 pushed a commit that referenced this pull request Jun 6, 2019
##  (2019-06-06)

* chore(composer): Upgrade dependencies ([03da9d8](03da9d8))
* chore(composer): Upgrade dev branch alias to 0.5.x-dev ([44d1c93](44d1c93))
* chore(swoole): Upgrade default tested version to 4.3.4 ([0be71fe](0be71fe))
* fix(config): set default host value to '0.0.0.0' (#55) ([2c9221d](2c9221d)), closes [#55](#55)
* docs(docker): Add demo project section ([b320c8d](b320c8d))
* docs(docker): Fix punctuation in "demo project" section ([3997d23](3997d23))
* docs(docker): Improve docker usage guide ([0afdc46](0afdc46))
* docs(docker): Improve wording ([784392e](784392e))
* docs(readme): Add "API Server" to list of bundle features ([23c63fb](23c63fb))
k911 pushed a commit that referenced this pull request Jun 6, 2019
##  (2019-06-06)

* chore(composer): Upgrade dependencies ([03da9d8](03da9d8))
* chore(composer): Upgrade dev branch alias to 0.5.x-dev ([44d1c93](44d1c93))
* chore(swoole): Upgrade default tested version to 4.3.4 ([0be71fe](0be71fe))
* fix(config): set default host value to '0.0.0.0' (#55) ([2c9221d](2c9221d)), closes [#55](#55)
* docs(docker): Add demo project section ([b320c8d](b320c8d))
* docs(docker): Fix punctuation in "demo project" section ([3997d23](3997d23))
* docs(docker): Improve docker usage guide ([0afdc46](0afdc46))
* docs(docker): Improve wording ([784392e](784392e))
* docs(readme): Add "API Server" to list of bundle features ([23c63fb](23c63fb))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is that a good idea to make the default host from 'localhost' to '0.0.0.0'?
3 participants