This repository has been archived by the owner on Jan 17, 2022. It is now read-only.
fix for #268 - fix(http): proper creation of $_SERVER['REQUEST_URI'] #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #269 +/- ##
=============================================
+ Coverage 85.47% 85.48% +0.01%
- Complexity 647 648 +1
=============================================
Files 91 91
Lines 2010 2012 +2
=============================================
+ Hits 1718 1720 +2
Misses 292 292
|
Rastusik
force-pushed
the
request_factory_fix
branch
from
17fda9e to
e57986f
Compare
|
Code Climate has analyzed commit e57986f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.4% (0.0% change). View more on Code Climate. |
k911
reviewed
Jul 7, 2020
|
I'll test it tommorow. Thanks |
k911
approved these changes
Jul 7, 2020
k911
added a commit
that referenced
this pull request
Jul 15, 2020
* docs(readme): clarify state of HMR in bundle (#275) ([1e49f07](1e49f07)), closes [#275](#275) [#264](#264) * fix(doctrine): autoconfigure EntityManagerHandler only when orm is available in symfony's container ([87ede15](87ede15)), closes [#274](#274) * fix(http): proper creation of $_SERVER['REQUEST_URI'] (#269) ([78bb42b](78bb42b)), closes [#269](#269) * test(issue-268): add e2e test to ensure no regressions (#273) ([b9df907](b9df907)), closes [#273](#273) [#268](#268) * build(deps-dev): bump friendsofphp/php-cs-fixer from 2.16.3 to 2.16.4 (#266) ([7acabd7](7acabd7)), closes [#266](#266) * build(deps-dev): bump phpspec/prophecy-phpunit from 2.0.0 to 2.0.1 (#271) ([623923d](623923d)), closes [#271](#271) * build(deps-dev): bump phpstan/phpstan from 0.12.30 to 0.12.31 (#265) ([4c750a7](4c750a7)), closes [#265](#265) * build(deps-dev): bump phpstan/phpstan from 0.12.31 to 0.12.32 (#267) ([334b88f](334b88f)), closes [#267](#267) * build(deps-dev): bump phpunit/phpunit from 9.2.5 to 9.2.6 (#272) ([2256702](2256702)), closes [#272](#272)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more complicated to call the request factory method and these two lines would need to be written anyway
Fixes #269