fix for log collecting in symfony profiler #242
Conversation
Rastusik
force-pushed
the
241_profiler_logs
branch
3 times, most recently
from
e1ed7ba to
1dc73ee
Compare
Codecov Report
@@ Coverage Diff @@
## develop #242 +/- ##
=============================================
- Coverage 85.62% 85.47% -0.15%
- Complexity 636 647 +11
=============================================
Files 89 91 +2
Lines 1989 2010 +21
=============================================
+ Hits 1703 1718 +15
- Misses 286 292 +6
|
|
@Rastusik Could you change commit author to yourself? |
|
sure, I just don't understand how it is possible that the commit is done by you |
|
@k911 I changed the commit author |
Rastusik
force-pushed
the
241_profiler_logs
branch
from
1dc73ee to
9b7735d
Compare
|
@Rastusik Thanks, the CI build failed but the problem is probably not due to your changes, I'll fix that then I'll start reviewing/merging this and other PRs |
|
@Rastusik could you please rebase against develop? I've fixed CI use, so you have to run composer upgrade too. |
Rastusik
force-pushed
the
241_profiler_logs
branch
from
9b7735d to
8b032c9
Compare
|
@k911 done |
Rastusik
force-pushed
the
241_profiler_logs
branch
from
8b032c9 to
be331f0
Compare
|
Looks fine, but I'd like to test it locally. Hopefully, I'll merge it today. |
|
@Rastusik After recent updates the |
Rastusik
force-pushed
the
241_profiler_logs
branch
from
be331f0 to
6e42a17
Compare
|
@k911 done |
|
Code Climate has analyzed commit 6e42a17 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 54.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.4% (-0.1% change). View more on Code Climate. |
|
@Rastusik Thanks for your contribution! Since, several features has been merged recently I'll release all of it after a short testing period (5-7) days. |
* build(deps-dev): bump doctrine/annotations from 1.10.2 to 1.10.3 (#223) ([94ef806](94ef806)), closes [#223](#223) * build(deps-dev): bump phpstan/phpstan from 0.12.28 to 0.12.29 (#249) ([ebf9ce1](ebf9ce1)), closes [#249](#249) * build(deps-dev): bump phpstan/phpstan-doctrine from 0.12.15 to 0.12.16 (#248) ([830a9ef](830a9ef)), closes [#248](#248) * build(deps-dev): bump phpstan/phpstan-doctrine from 0.12.16 to 0.12.17 (#263) ([d796528](d796528)), closes [#263](#263) * chore(composer): add suggestion to use pixelfederation/doctrine-resettable-em-bundle to be able to r ([496c5fe](496c5fe)), closes [#226](#226) * chore(composer): upgrade deps (#246) ([7e44a89](7e44a89)), closes [#246](#246) * chore(composer): upgrade deps (#262) ([c9b218a](c9b218a)), closes [#262](#262) * chore(deps): upgrade composer dependencies (#222) ([37d2517](37d2517)), closes [#222](#222) * fix(config): allow configuring worker and reactor counts using ENV variables (#244) ([d6b270a](d6b270a)), closes [#244](#244) * fix(profiler): make log collection in symfony profiler to work (#242) ([50fdd6f](50fdd6f)), closes [#242](#242) * refactor(error-handler): move to proper namespace (#251) ([4c1c3e9](4c1c3e9)), closes [#251](#251) * feat(blackfire): Add bridge for upscale/swoole-blackfire (#221) ([960ddb8](960ddb8)), closes [#221](#221) * feat(exception-handler): Add Symfony error/exception handler (#228) ([180d5e5](180d5e5)), closes [#228](#228) * feat(http-server): configurable mime types for advanced static files server (#240) ([07896a4](07896a4)), closes [#240](#240) * ci(circle): upgrade docker client image to v19.03.11 (#239) ([fe7b46c](fe7b46c)), closes [#239](#239)
Resolves #241