Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

CI: Fix release script #81

Closed
k911 opened this issue Nov 14, 2019 · 0 comments · Fixed by #82
Closed

CI: Fix release script #81

k911 opened this issue Nov 14, 2019 · 0 comments · Fixed by #82
Assignees
@k911
Labels
area/ci kind/bug/possible Something probably isn't working priority/important

Comments

@k911
Copy link
Owner

k911 commented Nov 14, 2019

Investigate issues with release script and fix it because a job in CricleCI with it failed two times now.

The responsible script source code: https://github.com/k911/swoole-bundle/blob/develop/.circleci/release-version.sh#L118-L128
Job: https://app.circleci.com/jobs/github/k911/swoole-bundle/1790
Output: https://circleci.com/api/v1.1/project/github/k911/swoole-bundle/1790/output/103/0?file=true
@k911 k911 added kind/bug/possible Something probably isn't working priority/important area/ci labels Nov 14, 2019
@k911 k911 self-assigned this Nov 14, 2019
k911 added a commit that referenced this issue Nov 30, 2019
@k911
ci(circle): Fix release script
0c7c2b8 
Closes #81 [hopefully]
@k911 k911 mentioned this issue Nov 30, 2019
Merged
k911 added a commit that referenced this issue Nov 30, 2019
@k911
ci(circle): Fix release script
b353e7e 
Closes #81 [hopefully]
@k911 k911 closed this as completed in #82 Nov 30, 2019
k911 added a commit that referenced this issue Nov 30, 2019
@k911
ci(circle): Fix release script (#82)
542a954 
Closes #81 [hopefully]
k911 added a commit that referenced this issue Nov 30, 2019
@k911
chore(release): v0.7.2 🎉
9557765 
* ci(circle): Fix release script (#82) ([542a954](542a954)), closes [#82](#82) [#81](#81)
* fix(composer): Resolve upgrade issues (#83) ([92285ac](92285ac)), closes [#83](#83)
k911 added a commit that referenced this issue Nov 30, 2019
@k911
ci(circle): Remove loop in bash release script
ed058cb 
Motivation: trying to fix circleci job failure (see #81)
k911 added a commit that referenced this issue Nov 30, 2019
@k911
Revert "ci(circle): Remove loop in bash release script"
a468ef7 
This reverts commit ed058cb.

Issue #81 has probably been caused by CircleCI feature called "auto-cancel
redundant builds". When release script pushed a new commit to master branch build was cancelled, because default branch
for this repository is `develop`, and builds are not cancelled
automatically with this feature only for default branches.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@k911 k911

Labels
area/ci kind/bug/possible Something probably isn't working priority/important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(circle): Fix release script k911/swoole-bundle
1 participant
@k911