Skip to content
This repository has been archived by the owner on Jan 17, 2022. It is now read-only.

Notice: Undefined index: APP_TRUSTED_HOSTS #5

Closed
Gemorroj opened this issue Sep 27, 2018 · 1 comment
Closed

Notice: Undefined index: APP_TRUSTED_HOSTS #5

Gemorroj opened this issue Sep 27, 2018 · 1 comment
Labels
kind/bug/possible Something probably isn't working

Comments

@Gemorroj
Copy link

caan't start app:

bin/console swoole:server:run

In AbstractServerStartCommand.php line 152:

  Notice: Undefined index: APP_TRUSTED_HOSTS
@Gemorroj
Copy link
Author

by default, symfony comments this env vars (.env.dist):

###> symfony/framework-bundle ###
APP_ENV=dev
APP_SECRET=secret
#TRUSTED_PROXIES=127.0.0.1,127.0.0.2
#TRUSTED_HOSTS=localhost,example.com
###< symfony/framework-bundle ###

@k911 k911 added the kind/bug/possible Something probably isn't working label Sep 27, 2018
k911 added a commit that referenced this issue Sep 30, 2018
@k911
fix(config): Add trusted_proxies and trusted_hosts
29749e3 
Explicit env variables were removed in favor of bundle configuration which allows setting custom env variables.
Additionally, support for overriding these values at runtime (from cli) was added. See:

```bash
$ bin/console s:s:r --help
```

BREAKING CHANGE:
  - Env APP_TRUSTED_HOSTS is no longer supported
  - Env APP_TRUSTED_PROXIES is no longer supported
  - Configuration 'swoole.http_server.services.debug' was renamed to 'swoole.http_server.services.debug_handler'
  - Configuration 'swoole.http_server.services.trust_all_proxies' was renamed to 'swoole.http_server.services.trust_all_proxies_handler'

Closes #5
k911 added a commit that referenced this issue Sep 30, 2018
@k911
fix(config): Add trusted_proxies and trusted_hosts
867103c 
Explicit env variables were removed in favor of bundle configuration which allows setting custom env variables.
Additionally, support for overriding these values at runtime (from cli) was added. See:

```bash
$ bin/console s:s:r --help
```

BREAKING CHANGE:
  - Env APP_TRUSTED_HOSTS is no longer supported
  - Env APP_TRUSTED_PROXIES is no longer supported
  - Configuration 'swoole.http_server.services.debug' is renamed to 'swoole.http_server.services.debug_handler'
  - Configuration 'swoole.http_server.services.trust_all_proxies' is renamed to 'swoole.http_server.services.trust_all_proxies_handler'

Closes #5
@k911 k911 mentioned this issue Sep 30, 2018
Merged
@k911 k911 closed this as completed in #7 Sep 30, 2018
k911 added a commit that referenced this issue Sep 30, 2018
@k911
fix(config): Add trusted_proxies and trusted_hosts
aae8873 
Explicit env variables were removed in favor of bundle configuration which allows setting custom env variables.
Additionally, support for overriding these values at runtime (from cli) was added. See:

```bash
$ bin/console s:s:r --help
```

BREAKING CHANGE:
  - Env APP_TRUSTED_HOSTS is no longer supported
  - Env APP_TRUSTED_PROXIES is no longer supported
  - Configuration 'swoole.http_server.services.debug' is renamed to 'swoole.http_server.services.debug_handler'
  - Configuration 'swoole.http_server.services.trust_all_proxies' is renamed to 'swoole.http_server.services.trust_all_proxies_handler'

Closes #5
k911 pushed a commit that referenced this issue Oct 7, 2018
chore(release): v0.2.0-dev 🎉
e42b3a0 
##  (2018-10-07)

* chore(composer): Upgrade dev branch alias ([084987b](084987b))
* chore(deps): Add explicit dependency on xdebug handler ([6f77d80](6f77d80))
* fix(command): Decode configuration one more time ([32f9776](32f9776))
* fix(config): Add trusted_proxies and trusted_hosts ([aae8873](aae8873)), closes [#5](#5)
* fix(configuration): Set proper service ids in symfony DI ([dda8c9d](dda8c9d))
* fix(swoole): Fix static file serving ([443bd13](443bd13))
* fix(swoole): Make swoole http server lazy (#132) ([04a7dcc](04a7dcc)), closes [#132](#132)
* ci(tests): Lock packages for testing library ([b4e7122](b4e7122))
* ci(travis): Fix semantic version bumping ([06127d2](06127d2))
* ci(travis): Install swoole php extension ([5d85abb](5d85abb))
* docs: Add README.md ([6bb933d](6bb933d))
* docs(config): Update command descriptions ([c0ed4cf](c0ed4cf))
* test: Add TrustAllProxiesRequestHandler tests ([7d57e4b](7d57e4b))
* test(app): Create test symfony app ([08e776b](08e776b))
* test(swoole): Fix HttpKernelHttpDriver test ([f5640b9](f5640b9))
* refactor(input): Check CLI input more agressively to make phpstan happy ([a046b8b](a046b8b))
* refactor(structrue): Reorganize package ([d7cd94c](d7cd94c))
* refactor(swoole): Improve configuration and DX ([ec92f23](ec92f23))
* refactor(swoole): Improve configuration and DX ([558e567](558e567))
* refactor(swoole): Introduce HttpServer class ([2b57c1e](2b57c1e))
* refactor(swoole): Introduce HttpServer class ([fe65ada](fe65ada))
* refactor(swoole): Move AtomicCounter to Memory\Atomic namespace ([c02bc9a](c02bc9a))
* refactor(swoole): Move AtomicCounter to Memory\Atomic namespace ([3770d87](3770d87))
* refactor(swoole): Provide AbstractServerCommand ([3512a46](3512a46))
* refactor(swoole): Provide AbstractServerCommand ([05598ec](05598ec))
* refactor(swoole): Simplify booting services at runtime ([5187396](5187396))
* refactor(swoole): Simplify booting services at runtime ([731ccec](731ccec))
* Add atomic counter test ([1b8cf92](1b8cf92))
* Add atomic counter test ([d2bafe9](d2bafe9))
* Change Docker entrypoint ([472a834](472a834))
* Code style fixes ([02b58b8](02b58b8))
* Configure DI for SwooleBundle ([5c4cf80](5c4cf80))
* Create basic symfony bundle configuration ([b11a078](b11a078))
* Create Driver architecture ([83995ef](83995ef))
* Create LimitedDriver for swoole:server:profile ([48cfede](48cfede))
* Create Swoole Driver interface ([440707e](440707e))
* Fix CI ([9d4e08c](9d4e08c))
* Initialize repository ([3ef71a3](3ef71a3))
* Make basic commands to set-up swoole server ([e6d8d3c](e6d8d3c))
* Optimize SwooleBundle interfaces ([3cf5764](3cf5764))
* Test SwooleBundle HttpDriver ([846ca32](846ca32))
* Test SwooleBundle HttpDriver ([eab7f84](eab7f84))
* Update dependencies ([1010264](1010264))
* Use DI to wire swoole bundle commands ([42b0126](42b0126))
* feat(swoole): Add ability to customize server ([3534ed0](3534ed0))
* feat(swoole): Add advanced static file serving ([17cde60](17cde60))
* feat(swoole): Allow to change publicdir at runtime ([c5a0c27](c5a0c27))
* feat(swoole): Disable Xdebug using XdebugHandler ([97ae8e7](97ae8e7))
* feat(swoole): Process and respond cookies ([0b7e883](0b7e883))
* feat(swoole): Use multiple http server workers ([8062a33](8062a33))
* perf(swoole): Improve Dependency Injection configuration ([b9f6ddc](b9f6ddc))
* perf(swoole): Improve Dependency Injection configuration ([6f83e11](6f83e11))
* perf(swoole): Use callable array form to handle request to avoid function call ([67e3154](67e3154))
* style(php-cs-fixer): Enforce @PHP71Migration:risky ruleset ([ac7a6e5](ac7a6e5))
* build(phpstan): Upgrade PHPStan to newest version (#137) ([19b5a3c](19b5a3c)), closes [#137](#137)

### BREAKING CHANGE

*   - Env APP_TRUSTED_HOSTS is no longer supported
  - Env APP_TRUSTED_PROXIES is no longer supported
  - Configuration 'swoole.http_server.services.debug' is renamed to 'swoole.http_server.services.debug_handler'
  - Configuration 'swoole.http_server.services.trust_all_proxies' is renamed to 'swoole.http_server.services.trust_all_proxies_handler'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug/possible Something probably isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gemorroj @k911