Rename method. Add missing return type hint.

k911 · Jul 30, 2020 · c189d77 · c189d77
1 parent 37b0b73
commit c189d77
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Bridge/Symfony/HttpFoundation/StreamedResponseListener.php b/src/Bridge/Symfony/HttpFoundation/StreamedResponseListener.php
@@ -22,7 +22,7 @@ public function __construct(
         $this->contextManager = $contextManager;
     }
 
-    public function onKernelResponse(ResponseEvent $event)
+    public function onKernelResponse(ResponseEvent $event): void
     {
         if (!$event->isMasterRequest()) {
             return;

diff --git a/src/Bridge/Symfony/HttpFoundation/SwooleRequestResponseContextManager.php b/src/Bridge/Symfony/HttpFoundation/SwooleRequestResponseContextManager.php
@@ -13,11 +13,11 @@ final class SwooleRequestResponseContextManager
     private const REQUEST_ATTR_KEY = 'swoole_request';
     private const RESPONSE_ATTR_KEY = 'swoole_response';
 
-    public function withRequestResponseAttributes(
+    public function attachRequestResponseAttributes(
         HttpFoundationRequest $request,
         SwooleRequest $swooleRequest,
         SwooleResponse $swooleResponse
-    ) {
+    ): void {
         $request->attributes->set(static::REQUEST_ATTR_KEY, $swooleRequest);
         $request->attributes->set(static::RESPONSE_ATTR_KEY, $swooleResponse);
     }

diff --git a/src/Bridge/Symfony/HttpKernel/HttpKernelRequestHandler.php b/src/Bridge/Symfony/HttpKernel/HttpKernelRequestHandler.php
@@ -51,7 +51,7 @@ public function boot(array $runtimeConfiguration = []): void
     public function handle(SwooleRequest $request, SwooleResponse $response): void
     {
         $httpFoundationRequest = $this->requestFactory->make($request);
-        $this->contextManager->withRequestResponseAttributes($httpFoundationRequest, $request, $response);
+        $this->contextManager->attachRequestResponseAttributes($httpFoundationRequest, $request, $response);
         $httpFoundationResponse = $this->kernel->handle($httpFoundationRequest);
         if (!$httpFoundationResponse instanceof StreamedResponse) {
             $this->responseProcessor->process($httpFoundationResponse, $response);