Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRD installation for tutorial #1037

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Update CRD installation for tutorial #1037

merged 1 commit into from
Jan 20, 2025

Conversation

Javex
Copy link
Contributor

@Javex Javex commented Jan 11, 2025

Summary

Similar to #977, the installation fails on the client side. Aligned with charts/k8up/README.md to suggest server side apply as well. Prevents an error message "metadata.annotations: Too long: must have at most 262144 bytes" for later CRD resources during installation.

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Commits are signed off
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

Similar to k8up-io#977, the installation fails on the client side. Aligned with charts/k8up/README.md to suggest server side apply as well. Prevents an error message "metadata.annotations: Too long: must have at most 262144 bytes" for later CRD resources during installation

Signed-off-by: javex <code@inexplicity.de>
@Javex Javex marked this pull request as ready for review January 11, 2025 10:21
@Javex Javex requested a review from a team as a code owner January 11, 2025 10:21
@Javex Javex requested review from tobru and lieneluksika and removed request for a team January 11, 2025 10:21
@tobru tobru enabled auto-merge January 20, 2025 07:42
@tobru tobru disabled auto-merge January 20, 2025 07:55
@tobru tobru merged commit 6258349 into k8up-io:master Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants