Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daemonset yaml #300

Merged

Conversation

adrianchiris
Copy link
Contributor

  • Add control-plane toleration
  • remove nodeSelector for amd64 arch as we have multi-arch images
  • rename ds - remove amd64 suffix

- Add control-plane toleration
- remove nodeSelector for amd64 arch as we have multi-arch images
- rename ds - remove amd64 suffix

Signed-off-by: adrianc <adrianc@nvidia.com>
@adrianchiris
Copy link
Contributor Author

@SchSeba @zeeke PTAL, small improvement.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9242873708

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.923%

Totals Coverage Status
Change from base Build 9241690155: 0.0%
Covered Lines: 662
Relevant Lines: 1300

💛 - Coveralls

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit aacf339 into k8snetworkplumbingwg:master May 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants