chore: Add OWNERS file #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killianmuldoon
force-pushed
the
pr-add-owners
branch
from
2f5f924 to
ed5bd20
Compare
Signed-off-by: killianmuldoon <cilliancapi@gmail.com>
killianmuldoon
force-pushed
the
pr-add-owners
branch
from
ed5bd20 to
bfe9de0
Compare
Pull Request Test Coverage Report for Build 8018102894Details
💛 - Coveralls |
killianmuldoon
commented
Feb 23, 2024
There was a problem hiding this comment.
@hustcat @dougbtv @SchSeba @adrianchiris @martinkennelly @zeeke @zshi-redhat @eoghanlawless @ahalimx86 @michaeloreillyintel @Eoghan1232
Would be good to get yeer feed back on this as the most impacted. I'll come to the next Network and Resource Management meeting and we can discuss it there too.
Comment on lines
+2
to
+8
| adrianchiris | ||
| dougbtv | ||
|
|
||
| ## Maintainers: People who can merge code in this repo. | ||
| zeeke | ||
| SchSeba | ||
| Eoghan1232 |
There was a problem hiding this comment.
I'm really looking for feedback on who should take these roles.
The current proposal is based on some simple ideas:
- removing roles the NPWG doesn't define in the governance doc
- remove folks who haven't contributed as a maintainer or admin in the last two years
- restrict admins to folks who are also NPWG org owners
|
filename -> CODEOWNERS |
adrianchiris
approved these changes
Feb 26, 2024
Eoghan1232
approved these changes
Feb 26, 2024
as discussed in meeting - this is not the codeowners file, but just a owners txt file listing folks. |
SchSeba
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an OWNERS file to the SR-IOV CNI project. This OWNERS file will be reflected into the github permissions for this project once merged.
Context
This proposed OWNERS file comes from discussion around the way the NPWG handles project roles which took place in recent community meetings.
A governance doc defining project roles and process is pending approval at k8snetworkplumbingwg/community#23 This change was discussed in the NPWG community meetings on Feb. 8th and Feb 22nd.
Changes
Currently SR-IOV CNI has the following owners:
After merging this PR this would be changed to: