Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vlan Proto #277

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Support vlan Proto #277

merged 1 commit into from
Oct 4, 2023

Conversation

mlguerrero12
Copy link
Contributor

@mlguerrero12 mlguerrero12 commented Jul 18, 2023 •
edited
Loading

This allows users to set the vlan protocol.

This depends on vishvananda/netlink#888

@mlguerrero12 mlguerrero12 marked this pull request as draft July 18, 2023 15:39
@coveralls
Copy link

coveralls commented Jul 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6394477514

  • 31 of 39 (79.49%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.6%) to 41.413%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/netlink_manager.go 0 2 0.0%
pkg/sriov/sriov.go 4 7 57.14%
pkg/utils/mocks/netlink_manager_mock.go 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
pkg/utils/mocks/netlink_manager_mock.go 1 84.56%
pkg/utils/netlink_manager.go 1 0.0%
pkg/sriov/sriov.go 2 37.62%
Totals Coverage Status
Change from base Build 6063244640: 2.6%
Covered Lines: 463
Relevant Lines: 1118
💛 - Coveralls

@SchSeba
Copy link
Collaborator

SchSeba commented Jul 26, 2023

/hold

@mlguerrero12 mlguerrero12 mentioned this pull request Aug 8, 2023
Merged
@mlguerrero12 mlguerrero12 force-pushed the supportvlanproto branch 2 times, most recently from 8a6de99 to bab740b Compare September 11, 2023 13:30
@mlguerrero12 mlguerrero12 marked this pull request as ready for review September 11, 2023 13:31
@mlguerrero12
Copy link
Contributor Author

@SchSeba, @adrianchiris, netlink PR got merged. This one is now ready. Please have a look when you have time.

@mlguerrero12
Copy link
Contributor Author

(added vlanProto in configuration reference)

@SchSeba, @zeeke, @Eoghan1232, could you please have a look at this? Thanks.

Eoghan1232
Eoghan1232 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

adrianchiris
adrianchiris reviewed Oct 3, 2023
View reviewed changes
pkg/sriov/sriov.go Outdated Show resolved Hide resolved
@mlguerrero12
Support vlan Proto
6217a32 
This allows users to set the vlan protocol.

Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
@zeeke
Copy link
Member

zeeke commented Oct 4, 2023

LGTM

@zeeke zeeke merged commit f0e62c3 into k8snetworkplumbingwg:master Oct 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mlguerrero12 @coveralls @SchSeba @zeeke @adrianchiris @Eoghan1232