Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to revert VF trust #258

Merged

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented May 10, 2023

now netlink support getting the trust info from the vf so we can remove the TODO :)

@coveralls
Copy link

coveralls commented May 10, 2023

Pull Request Test Coverage Report for Build 4981252261

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 38.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/sriov/sriov.go 1 2 50.0%
pkg/types/types.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
pkg/sriov/sriov.go 1 39.11%
Totals Coverage Status
Change from base Build 4784483752: 0.04%
Covered Lines: 424
Relevant Lines: 1110

💛 - Coveralls

pkg/sriov/sriov.go Outdated Show resolved Hide resolved
@SchSeba SchSeba force-pushed the support_trust_restore branch from 351d1ec to ec788e6 Compare May 15, 2023 13:57
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/types/types.go Outdated Show resolved Hide resolved
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@SchSeba SchSeba force-pushed the support_trust_restore branch from ec788e6 to bf485ab Compare May 24, 2023 10:53
@mlguerrero12
Copy link
Contributor

LGTM

@SchSeba
Copy link
Collaborator Author

SchSeba commented May 28, 2023

Hi @adrianchiris can you take another look?

@adrianchiris adrianchiris merged commit aa5c230 into k8snetworkplumbingwg:master May 28, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5067782557

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 38.1%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/sriov/sriov.go 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/sriov/sriov.go 1 39.11%
Totals Coverage Status
Change from base Build 5046853371: -0.06%
Covered Lines: 421
Relevant Lines: 1105

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants