-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to revert VF trust #258
Merged
adrianchiris
merged 1 commit into
k8snetworkplumbingwg:master
from
SchSeba:support_trust_restore
May 28, 2023
Merged
Add support to revert VF trust #258
adrianchiris
merged 1 commit into
k8snetworkplumbingwg:master
from
SchSeba:support_trust_restore
May 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4981252261
💛 - Coveralls |
zeeke
reviewed
May 11, 2023
SchSeba
force-pushed
the
support_trust_restore
branch
from
May 15, 2023 13:57
351d1ec
to
ec788e6
Compare
zeeke
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
SchSeba
force-pushed
the
support_trust_restore
branch
from
May 24, 2023 10:53
ec788e6
to
bf485ab
Compare
LGTM |
Hi @adrianchiris can you take another look? |
adrianchiris
approved these changes
May 28, 2023
Pull Request Test Coverage Report for Build 5067782557Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now netlink support getting the trust info from the vf so we can remove the TODO :)